Improved Change Passwd by adding Gateway Passwd #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Benouch , your patch is very interesting. But this github repository is only a secondary mirror of the main gitlab repository here: https://gitlab.com/Remmina/Remmina/ Thank you. |
|
Yes, I will try.
…On Wed, Aug 31, 2022 at 3:59 PM Giovanni Panozzo ***@***.***> wrote:
Hi @Benouch <https://github.com/Benouch> , your patch is very
interesting. But this github repository is only a secondary mirror of the
main gitlab repository here: https://gitlab.com/Remmina/Remmina/
Could you please create the same MR in GitLab ?
Thank you.
—
Reply to this email directly, view it on GitHub
<#1694 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6XV3N4643HVW3JS3C6Y7DV362RJANCNFSM6AAAAAAQBV4GIU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I believe I recreated the exact same thing on gitlab.
Let me know if anything.
…On Wed, Aug 31, 2022 at 3:59 PM Giovanni Panozzo ***@***.***> wrote:
Hi @Benouch <https://github.com/Benouch> , your patch is very
interesting. But this github repository is only a secondary mirror of the
main gitlab repository here: https://gitlab.com/Remmina/Remmina/
Could you please create the same MR in GitLab ?
Thank you.
—
Reply to this email directly, view it on GitHub
<#1694 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6XV3N4643HVW3JS3C6Y7DV362RJANCNFSM6AAAAAAQBV4GIU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
We don't see it, can you please link the merge request? |
|
Is this it?
https://gitlab.com/benoit.lagarde/Remmina/-/merge_requests/1
On Wed, Aug 31, 2022, 7:19 PM Antenore Gatta ***@***.***>
wrote:
… I believe I recreated the exact same thing on gitlab. Let me know if
anything.
… <#m_-5748571225646374484_>
On Wed, Aug 31, 2022 at 3:59 PM Giovanni Panozzo *@*.*> wrote: Hi
@Benouch <https://github.com/Benouch> https://github.com/Benouch
<https://github.com/Benouch> , your patch is very interesting. But this
github repository is only a secondary mirror of the main gitlab repository
here: https://gitlab.com/Remmina/Remmina/
<https://gitlab.com/Remmina/Remmina/> Could you please create the same MR
in GitLab ? Thank you. — Reply to this email directly, view it on GitHub
<#1694 (comment)
<#1694 (comment)>>, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AA6XV3N4643HVW3JS3C6Y7DV362RJANCNFSM6AAAAAAQBV4GIU
<https://github.com/notifications/unsubscribe-auth/AA6XV3N4643HVW3JS3C6Y7DV362RJANCNFSM6AAAAAAQBV4GIU>
. You are receiving this because you were mentioned.Message ID: @.*>
We don't see it, can you please link the merge request?
—
Reply to this email directly, view it on GitHub
<#1694 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6XV3MQEAEM547LZF2KBULV37R6TANCNFSM6AAAAAAQBV4GIU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
This is in your fork, you must submit a new MR at https://gitlab.com/Remmina/Remmina/-/merge_requests/new |
|
Like I said it's my first time!
I'll fork it on your repository
…On Thu, Sep 1, 2022, 12:56 AM Antenore Gatta ***@***.***> wrote:
This is in your fork, you must submit a new MR at
https://gitlab.com/Remmina/Remmina/-/merge_requests/new
—
Reply to this email directly, view it on GitHub
<#1694 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6XV3PKA6V5AAXDUIZQLXLV4AZPHANCNFSM6AAAAAAQBV4GIU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
If I'm not wrong, the correct procedure should be:
|
|
I followed that procedure.
You should now see the merge request.
…On Thu, Sep 1, 2022 at 8:07 AM Giovanni Panozzo ***@***.***> wrote:
If I'm not wrong, the correct procedure should be:
1. In gitlab.com fork the main Remmina repository to your personal
repository (and you already did it one time, I think)
2. In your personal repository on gitlab create a new branch and add
your code to this new branch
3. Create a Merge Request from your repo/branch to the master branch
of remmina repository (all in Gitlab)
—
Reply to this email directly, view it on GitHub
<#1694 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6XV3NJDX6KH6KKBM5RVBTV4CL67ANCNFSM6AAAAAAQBV4GIU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I've improved on the change password feature of Remmina.
I've added the ability to also change the Gateway Password in mass.
I don't know if this has ever been requested but for me it is an essential feature since I use Remmina for a professional purpose and of course my password changes every so often. And since I use a RD Gateway to connect to Windows servers changing my Gateway password had become a chore.
I've haven't created any translations for the new labels. I'll be happy to do it for languages I know.
Thank you.
FYI it's my first pull/merge request so let me know if what I'm doing is correct.