Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct BrowserKitFactory to support the 'http_client_parameters' option #23

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

BastienGarcia
Copy link

Follow up to #22.

A new option to configure the BrowserKitDriver client was added in the previous PR, however, the configuration could not be added to the configuration file as it would return the following error: Unrecognized option "http_client_parameters".
This PR allows the use of the option, for exemple:

default:
  suites:
    default:
      path: "%paths.base%/features"
      contexts: [Behat\MinkExtension\Context\MinkContext]
  extensions:
    Behat\MinkExtension:
      base_url: http://en.wikipedia.org/
      sessions:
        default:
          browserkit_http:
            http_client_parameters:
                verify_host: false
                verify_peer: false

@stronk7
Copy link

stronk7 commented Sep 15, 2023

Nice one @BastienGarcia.

Hope this is accepted and rolled into a minor release (we certainly need to be able to, exactly, disable those cert verifications here for some good tests to proceed!

@BastienGarcia
Copy link
Author

@Yozhef sorry for pinging you once again

@Yozhef Yozhef merged commit 18d5a53 into FriendsOfBehat:master Oct 3, 2023
9 checks passed
@Yozhef
Copy link

Yozhef commented Oct 3, 2023

@BastienGarcia I am very sorry for the long answer, unfortunately there is a war going on in my country and I cannot allocate enough time at the moment (Please accept my apologies
Release 2.7.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants