-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/generic string #1050
Open
ThibautVerron
wants to merge
15
commits into
Fuco1:master
Choose a base branch
from
ThibautVerron:feature/generic-string
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/generic string #1050
+31
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Or should I do it and offer to merge a clean branch? |
No problem with the squash, GitHub can do it automatically when merging. Thank you for the PR, I'll review it shortly. |
Ping? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a pull request for the code related to the generic string delimiters ( #1039 ). You might want to squash the history, the last commits were very messy (sorry about that).
It turns out that this:
is no longer a problem.
But on the other hand, I don't know how to do it again if we were to decide that it is the wanted behaviour. Something seems to be overriding the detection of the string somewhere in sp-get-expression.
Emacs' default sexp navigation (using syntax tables) correctly navigates to the beginning of the string in the same scenario.
Thanks for your work ! :)