Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LaTeX tests with delete-selection on #1208

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

temyurchenko
Copy link
Contributor

@temyurchenko temyurchenko commented May 18, 2024

The tests fail on the current version of auctex, but pass on the most recent one
https://git.savannah.gnu.org/cgit/auctex.git/log/

I'm not sure what's the best way to approach this is.
AUCTeX used to have improper delete-selection properties on its «smart» functions. Even when the «smart» behaviour was turned off, the delete-selection property was overriden, causing smartparens functions to fail (see the tests).

The patch fixing AUCTeX (unfortunately, not the quotes) has been accepted and is already in master. With that patch and this patch to smartparens, the tests will pass successfully.

@Fuco1
Copy link
Owner

Fuco1 commented May 20, 2024

This is a great start but we need to make sure somehow to respect the older versions of Emacs / Auctex. Maybe there is some condition that we can test (for example value of the delete-selection properties?) and only remove the commands from the "special" lists then, not always. Given the rather slow release cycles of things surrounding Emacs, I think we need to be a bit careful not to remove something too soon.

@temyurchenko
Copy link
Contributor Author

This is a great start but we need to make sure somehow to respect the older versions of Emacs / Auctex. Maybe there is some condition that we can test (for example value of the delete-selection properties?) and only remove the commands from the "special" lists then, not always. Given the rather slow release cycles of things surrounding Emacs, I think we need to be a bit careful not to remove something too soon.

Hey, that's reasonable. I've conditioned inclusion of TeX-insert-dollar (which is the only regression) on the auctex version.

@temyurchenko
Copy link
Contributor Author

(this should also eventually close #1048)

@temyurchenko
Copy link
Contributor Author

(a gentle ping, @Fuco1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants