Fuel/Request_Response v0.0.2: More meaningful error messages #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l in the PeerManager table
…the request response protocol to use
This reverts commit f3b7db3b0f4aa92f2606c87ed6f65f4798734889.
…ses to unsuccessful requests
acerone85
requested review from
xgreenx,
Dentosal and
MitchTurner
as code owners
acerone85
changed the base branch from
release/v0.40.0
to
1311-return-better-error-messages-from-p2p-requests
acerone85
force-pushed
the
1311-return-better-error-messages-from-p2p-requests-pt-2
branch
from
11000a8
to
7b2bf3b
Compare
acerone85
force-pushed
the
1311-return-better-error-messages-from-p2p-requests-pt-2
branch
from
7b2bf3b
to
1bc4253
Compare
Base automatically changed from
1311-return-better-error-messages-from-p2p-requests
to
master
October 22, 2024 12:46
acerone85
changed the title
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
Closes #1311
Description
This PR follows #2362, which introduces a new version of the protocol
/fuel/req_response/0.0.2which allows to return Errors in the response. This PR makes the following changes:ResponseSenderused by a peer to propagate received responses upstream is changed to allow the rrors to be propagatedwarninglevel.Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]