Filsnap Demo #8
Merged
Filsnap Demo #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it looks good but AFAICS its not actually using the filsnap API and the tx insights are not even returning anything (which is probably a bug). |
hugomrdias
suggested changes
Sep 12, 2023
src/routes/filfund/components/FundRingWidget/Disconnected.svelte
Outdated
Show resolved
Hide resolved
src/routes/filfund/components/FundRingWidget/Disconnected.svelte
Outdated
Show resolved
Hide resolved
src/routes/filfund/components/FundRingWidget/Disconnected.svelte
Outdated
Show resolved
Hide resolved
… and rpc instance
|
thanks @hugomrdias! I've updated the PR as per your feedback 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/filfundroute that allows funds to be contributed to the widget via filsnap using native FILLink to issue
Please add a link to any relevant issues/tickets
Type of change
Screencast
https://www.loom.com/share/aa6467fd17f8414590b0c71b660d631b?sid=d7ea6681-4808-4530-b186-0be555b732c3
Staging Domain
https://fundring-filsnap.fission.app/