Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leakage test #75

Closed
wants to merge 41 commits into from
Closed

Leakage test #75

wants to merge 41 commits into from

Conversation

selcan-k
Copy link
Contributor

@selcan-k selcan-k commented Jul 4, 2024 •
edited
Loading

Description

An Ontology for a leakage test.

Type of change

Please delete options that are not relevant.

  • New type (non-breaking change which adds a type)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any
relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • My code follows the modelling guidelines of this project
  • I have performed a self-review of my own changes

lenasauermann
lenasauermann requested changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@lenasauermann lenasauermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All variables names for classes and varables must be in english.
The name of the classes must be in PascalCase. Example: Sensor
The attributes of the classes must be in camelCase. Example: sensorType

MaschinenparameterShape and ProzessparameterShape are missing.

#57 Please add Ontology-Class for every Shape as described in this issue.

robertschubert and others added 23 commits July 9, 2024 09:36
@robertschubert @selcan-k
corrected readme (path to ttl) (#60)
90f131c 
Co-authored-by: schuberr <[email protected]>
@3Dbastian @selcan-k
correction of country and state pattern, correction of instance
90c7cc3 
Signed-off-by: 3Dbastian <[email protected]>

Signed-off-by: Sebastian_3DMS <[email protected]>
@3Dbastian @selcan-k
correction of name of instance file
0016970 
Signed-off-by: Sebastian_3DMS <[email protected]>
@JustinDxx @selcan-k
Add VARIABLES.md files
ea9e303 
Signed-off-by: GitHub Action <[email protected]>
Signed-off-by: Sebastian_3DMS <[email protected]>
Signed-off-by: selcan-k <[email protected]>
@robertschubert @JustinDxx @selcan-k
new correction for participant linkage (#65)
cde32ac 
* added new correction from sh:class to sh:node (reason see README.md)

* Add VARIABLES.md files

Signed-off-by: GitHub Action <[email protected]>

---------

Signed-off-by: GitHub Action <[email protected]>
Co-authored-by: schuberr <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
@heuerfin @selcan-k
Fixed conformance with shacle
cfd7bb7 
Signed-off-by: Fin Heuer <[email protected]>
@selcan-k
Files for Leakage Test
03f18ac 
Files for Leakage Test

Signed-off-by: selcan-k <[email protected]>
@selcan-k
Update leakage-test_shacl.ttl
21d326f 
Signed-off-by: selcan-k <[email protected]>
@JustinDxx @selcan-k
Add VARIABLES.md files
c50ab97 
Signed-off-by: GitHub Action <[email protected]>
Signed-off-by: selcan-k <[email protected]>
@selcan-k
Update leakage-test_shacl.ttl
a66c813 
Signed-off-by: selcan-k <[email protected]>
@selcan-k
Update leakage-test_shacl.ttl
bbfbc14 
Signed-off-by: selcan-k <[email protected]>
@selcan-k
Update leakage-test_shacl.ttl
370744a 
Signed-off-by: selcan-k <[email protected]>
@JustinDxx @selcan-k
Add VARIABLES.md files
8260d35 
Signed-off-by: GitHub Action <[email protected]>
Signed-off-by: selcan-k <[email protected]>
@selcan-k
Update leakage-test_shacl.ttl
d9c54f6 
Signed-off-by: selcan-k <[email protected]>
@JustinDxx @selcan-k
Add VARIABLES.md files
83370ce 
Signed-off-by: GitHub Action <[email protected]>
Signed-off-by: selcan-k <[email protected]>
@selcan-k
Update leakage-test_shacl.ttl
e1f8b52 
Signed-off-by: selcan-k <[email protected]>
@JustinDxx @selcan-k
Add VARIABLES.md files
b68d5b3 
Signed-off-by: GitHub Action <[email protected]>
Signed-off-by: selcan-k <[email protected]>
@selcan-k
Update leakage-test_shacl.ttl
6ab3a4b 
Signed-off-by: selcan-k <[email protected]>
@JustinDxx @selcan-k
Add VARIABLES.md files
51899c1 
Signed-off-by: GitHub Action <[email protected]>
Signed-off-by: selcan-k <[email protected]>
@selcan-k
Update leakage-test_shacl.ttl
bdbbaa3 
Signed-off-by: selcan-k <[email protected]>
@selcan-k
Update leakage-test_shacl.ttl
73f6659 
Signed-off-by: selcan-k <[email protected]>
@robertschubert @selcan-k
added another log line to inform which file is validated. (#72)
7089619 
Co-authored-by: schuberr <[email protected]>
@robertschubert @selcan-k
bugfix in ci pipeline if more than one file was found to be processed…
04fbd0a 
… and stored in the GITHUB-ENV. (#74)

Also Bugfix when having several instance files to be checked: Add them together into the data graph since they might reference each other.

Co-authored-by: schuberr <[email protected]>
selcan-k and others added 17 commits July 9, 2024 09:39
@selcan-k
Update leakage-test_ontology.ttl
6c6d58a 
Signed-off-by: selcan-k <[email protected]>
@selcan-k
Update leakage-test_ontology.ttl
29aafad 
Signed-off-by: selcan-k <[email protected]>
@selcan-k
Update leakage-test_ontology.ttl
3c124ad 
Signed-off-by: selcan-k <[email protected]>
@selcan-k
Update leakage-test_ontology.ttl
1d9674c 
Signed-off-by: selcan-k <[email protected]>
@selcan-k
Update leakage-test_shacl.ttl
adec0d1 
Signed-off-by: selcan-k <[email protected]>
@selcan-k
Update leakage-test_ontology.ttl
86ff487 
Signed-off-by: selcan-k <[email protected]>
@selcan-k
Update leakage-test_shacl.ttl
b9c4f3d 
Signed-off-by: selcan-k <[email protected]>
@selcan-k
Update leakage-test_ontology.ttl
b57b0b9 
Signed-off-by: selcan-k <[email protected]>
@selcan-k
Update leakage-test_ontology.ttl
ad651b2 
Signed-off-by: selcan-k <[email protected]>
@selcan-k
Update leakage-test_ontology.ttl
f540eb8 
Signed-off-by: selcan-k <[email protected]>
@selcan-k
added links for the github repositories the sd-creation-wizard is at.
a52bd11
@lenasauermann @selcan-k
added details to modeling guidelines and known issues (#76)
c10d1ad 
* added details to modeling guidelines and known issues

Signed-off-by: Lena Sauermann <[email protected]>

* fix review comments

Signed-off by: Lena Sauermann <[email protected]>

* fixes based on review comments

Signed-off-by: Lena Sauermann <[email protected]>

* remove comment about instance files

Signed-off-by: Lena Sauermann <[email protected]>

---------

Signed-off-by: Lena Sauermann <[email protected]>
Co-authored-by: schuberr <[email protected]>
@selcan-k
Update leakage-test_instance.json
4ce6fdc 
Signed-off-by: selcan-k <[email protected]>
@selcan-k
Update leakage-test_shacl.ttl
a50bb3b 
Signed-off-by: selcan-k <[email protected]>
@JustinDxx @selcan-k
Add VARIABLES.md files
915b692 
Signed-off-by: GitHub Action <[email protected]>
@selcan-k
Update leakage-test_shacl.ttl
8cfdfee 
Signed-off-by: selcan-k <[email protected]>
@JustinDxx @selcan-k
Add VARIABLES.md files
9ff1bba 
Signed-off-by: GitHub Action <[email protected]>
@selcan-k selcan-k closed this Jul 9, 2024
@selcan-k selcan-k deleted the leakage-test branch July 9, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenasauermann lenasauermann lenasauermann requested changes

@3Dbastian 3Dbastian Awaiting requested review from 3Dbastian

@MircoNierenz MircoNierenz Awaiting requested review from MircoNierenz

@robertschubert robertschubert Awaiting requested review from robertschubert robertschubert is a code owner

@JustinDxx JustinDxx Awaiting requested review from JustinDxx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@selcan-k @lenasauermann @robertschubert @3Dbastian @JustinDxx @heuerfin