Task/86 markdown description #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…page & ontology cards)
devbysp
requested changes
Sep 27, 2024
src/common/markdown/GMarkdown.tsx
Outdated
| maxContentHeight?: number; | ||
| }; | ||
|
|
||
| const GMarkdown: React.FC<GMarkdownProps> = ({ isCard, maxContentHeight = 200, children }) => { |
There was a problem hiding this comment.
There might be other type of files like some helpers, hooks, services, ... which will be created in the common. Therefore can you please create a 'components' folder inside the 'common' and move your markdown component and css into that. Something like src/common/components/markdown/GMakdown.tsx
src/components/detailsPage/pages/resources/ResourcesDetailsPage.tsx
Outdated
Show resolved
Hide resolved
src/components/detailsPage/pages/resources/ResourcesDetailsPage.tsx
Outdated
Show resolved
Hide resolved
src/components/detailsPage/pages/resources/ResourcesDetailsPage.tsx
Outdated
Show resolved
Hide resolved
src/components/detailsPage/pages/resources/ResourcesDetailsPage.tsx
Outdated
Show resolved
Hide resolved
src/components/detailsPage/pages/resources/ResourcesMainContent.tsx
Outdated
Show resolved
Hide resolved
src/components/detailsPage/pages/resources/ResourcesDetailsPage.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Keresztes Zsolt <[email protected]>
Signed-off-by: Keresztes Zsolt <[email protected]>
devbysp
requested changes
Sep 30, 2024
Signed-off-by: Keresztes Zsolt <[email protected]>
devbysp
approved these changes
Oct 1, 2024
Huber-David
approved these changes
Oct 7, 2024
# Conflicts: # src/components/ItemCard/ItemCard.tsx # src/components/Routes.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.