Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation of conversation #46

Closed
wants to merge 3 commits into from
Closed

Conversation

niknal357
Copy link
Collaborator

No description provided.

@niknal357
Copy link
Collaborator Author

I began playing around with the bot responding to messages without mentions and based on conversation, and it seems to work very well

I don't know how this is going to impact the billing and LLM usage, it obviously doesn't pipe through every message.
It is based on "has the bot said something in the last 3 messages, and has that been less than 150 seconds ago".
which is a pretty tight attention window.

maybe we should make a role that you need to have for shappie to consider engaging in a conversation

@niknal357 niknal357 marked this pull request as draft June 28, 2023 12:01
@niknal357
Copy link
Collaborator Author

This addresses issues #44 and #37

@@ -15,7 +15,7 @@ def _format_chat_messages(
is_bot = message.author.bot
username = message.author.display_name
role = "assistant" if is_bot else "user"
content = message.content if is_bot else f"{message.content} [User: {username}]"
content = message.content if is_bot else f"{message.content} [User: <{username}>]"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes the part of #22 that makes him say [User: username] as part of the response.

Base automatically changed from feature/dashboard to main June 29, 2023 21:48
@niknal357
Copy link
Collaborator Author

@niknal357 niknal357 closed this Jul 17, 2023
@niknal357 niknal357 deleted the feature/natural_conversation branch July 21, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant