feat: exception handling #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/16-exception-handling
uwoobeat
requested changes
Jan 30, 2024
| @@ -83,7 +85,7 @@ public AccessTokenDto parseAccessToken(String accessTokenValue) throws ExpiredJw | |||
| } catch (ExpiredJwtException e) { | |||
| throw e; | |||
| } catch (Exception e) { | |||
| return null; | |||
There was a problem hiding this comment.
null로 리턴하는거 의도한 부분인데 수정한 이유가 있나요?
There was a problem hiding this comment.
만료 이외의 예외는 null을 반환해서 재발급 과정을 거치기보다 예외를 던지는 것이 적절한 것 같아 수정했습니다!
There was a problem hiding this comment.
만료 이외의 예외가 발생해서 JwtFilter 의 line 52 로직을 타더라도, reissueAccessTokenIfExpired 에서 ExpiredJwtException 에 잡히지 않아 null로 반환되기 때문에 isPresent 로직을 타지 않아서 재발급이 이루어지지 않습니다.
로직 다시 한번 체크해보실래요?
There was a problem hiding this comment.
잡히지 않는 이유를 확인해본 결과,
reissueAccessTokenIfExpired에 AT가 아닌 RT를 넘겨서 ExpiredJwtException이 아닌 SignatureException이 발생하는 것이 원인이었습니다.
이외에도 JwtService.getRefreshTokenFromRedis의 내부를 조금 수정했으니 같이 확인 부탁드립니다!
| @@ -42,11 +42,7 @@ private void saveRefreshTokenToRedis(RefreshTokenDto refreshTokenDto) { | |||
| } | |||
|
|
|||
| public AccessTokenDto retrieveAccessToken(String accessTokenValue) { | |||
There was a problem hiding this comment.
이 부분은 제가 착각했습니다.
아래와 같이 수정하는 게 좋겠네요
try {
return jwtUtil.parseAccessToken(accessTokenValue);
} catch (ExpiredJwtException e) {
return null;
}기존 메서드는 데이터의 유무와 무관하게 항상 비어있는 Optional을 반환함. 사용하지 않는 Repository의 메서드는 제거함.
accessToken을 받아야 하는 메서드인데 refreshToken을 받고 있었음.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항