-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 프로파일 분리 및 운영환경 유틸리티 관련 기능 추가 #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
하나만 확인 부탁드려요~
httpSecurity | ||
.httpBasic(AbstractHttpConfigurer::disable) | ||
public SecurityFilterChain filterChain(HttpSecurity http) throws Exception { | ||
http.httpBasic(AbstractHttpConfigurer::disable) | ||
.formLogin(AbstractHttpConfigurer::disable) | ||
.csrf(AbstractHttpConfigurer::disable) | ||
.cors(withDefaults()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분은 수정 필요없나요?
.cors().configurationSource(corsConfigurationSource())
가 되어야 하는게 아닌가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.withDefaults()
사용하더라도 커스터마이징된 설정을 로드하기 때문에 괜찮습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🌱 관련 이슈
📌 작업 내용 및 특이사항
application.yml
을 운영환경에 맞게 분리했습니다. (local, dev, ...)📝 참고사항
📚 기타