feat: 멤버 탈퇴 api 구현 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uwoobeat
approved these changes
Feb 6, 2024
uwoobeat
requested changes
Feb 9, 2024
| @@ -86,4 +89,15 @@ public static Member createGuestMember(String oauthId) { | |||
| .status(MemberStatus.NORMAL) | |||
| .build(); | |||
| } | |||
|
|
|||
| public void softDelete() { | |||
| if (this.status.isDeleted()) { | |||
There was a problem hiding this comment.
Suggested change
| if (this.status.isDeleted()) { | |
| if (isDeleted()) { |
uwoobeat
requested changes
Feb 9, 2024
There was a problem hiding this comment.
soft delete와 hard delete는 DB 상에서의 삭제 구현 방식에 대한 논의이지,
애플리케이션 단에서 특수하게 둘을 구분할 필요가 없고 구분해야 하는 요구사항도 없습니다.
애플리케이션에서 예외 상황을 구별해야 한다면 삭제 했냐 / 안했냐에 대한 문제이지 DB 삭제 방식까지 구별해야 하는 것은 아닙니다.
요약하자면 우리 서비스에서 soft delete / hard delete 라는 지식을 가지고 있을 필요가 없습니다. 오히려 도메인 메서드나 예외 코드가 고정되어 버리면 추후 하드 딜리트로 넘어가는 상황에서 대처하기도 어렵습니다. 이 부분에 대해서 수정이 필요해 보입니다.
| @@ -86,4 +89,15 @@ public static Member createGuestMember(String oauthId) { | |||
| .status(MemberStatus.NORMAL) | |||
| .build(); | |||
| } | |||
|
|
|||
| public void softDelete() { | |||
There was a problem hiding this comment.
Suggested change
| public void softDelete() { | |
| public void withdraw() { |
의미를 더 잘 드러낼 수 있는 메서드 이름을 써주면 좋을 것 같습니다.
uwoobeat
approved these changes
Feb 9, 2024
|
|
||
| // Member | ||
| MEMBER_NOT_FOUND(HttpStatus.NOT_FOUND, "존재하지 않는 회원입니다."), | ||
| MEMBER_DELETED(HttpStatus.BAD_REQUEST, "탈퇴한 회원입니다."); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항