Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 어드민 멤버 가입신청 승인하기 api 구현 #63

Merged
merged 10 commits into from
Feb 12, 2024

Conversation

Sangwook02
Copy link
Member

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • 승인할 멤버들의 id(pk)를 리스트로 받아서 승인된 멤버들의 id만 모아서 리스트로 반환합니다.
  • 3가지 requirement(재학생, 회비, 디스코드)의 승인 여부는 쿼리에서 확인하도록 구현했습니다.

📝 참고사항

📚 기타

@Sangwook02 Sangwook02 added the ✨ feature 새로운 기능 추가 및 수정 label Feb 12, 2024
@Sangwook02 Sangwook02 self-assigned this Feb 12, 2024
@Sangwook02 Sangwook02 requested a review from a team as a code owner February 12, 2024 09:45
Copy link
Member

@uwoobeat uwoobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm


private BooleanBuilder requirementVerified(Long id) {
return new BooleanBuilder()
.and(eqId(id))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eqId는 별도로 빼도 되지 않을까요?

Copy link
Member Author

@Sangwook02 Sangwook02 Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그게 메서드명이랑 더 잘 맞겠네요
밖으로 빼겠습니다

Copy link
Member

@uwoobeat uwoobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sangwook02 Sangwook02 merged commit 03751fa into develop Feb 12, 2024
1 check passed
@Sangwook02 Sangwook02 deleted the feature/23-member-approval branch February 12, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature 새로운 기능 추가 및 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ 어드민 멤버 가입신청 승인하기 API 구현
2 participants