Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 과제 응답 DTO에 커리큘럼 시작일 추가 #753

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Sangwook02
Copy link
Member

@Sangwook02 Sangwook02 commented Sep 4, 2024

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • 프론트측 요청으로 과제 응답에 커리큘럼 시작일 필드를 추가했습니다.

📝 참고사항

📚 기타

Summary by CodeRabbit

  • 새로운 기능

    • 과제 응답에 "커리큘럼 시작일" 필드 추가로 과제에 대한 추가 정보 제공.
  • 버그 수정

    • 과제 데이터 구조 개선으로 더 정확한 정보 표현.

@Sangwook02 Sangwook02 self-assigned this Sep 4, 2024
@Sangwook02 Sangwook02 requested a review from a team as a code owner September 4, 2024 11:33
Copy link

coderabbitai bot commented Sep 4, 2024

Walkthrough

AssignmentResponse 클래스에 curriculumStartAt이라는 새로운 필드가 추가되었습니다. 이 필드는 LocalTime 타입으로, 커리큘럼 시작일을 나타내며, 생성자와 from 메서드에서 해당 필드를 처리하는 로직이 업데이트되었습니다. 이로 인해 과제 데이터 구조가 확장되었습니다.

Changes

파일 경로 변경 요약
src/main/java/com/gdschongik/gdsc/domain/study/dto/response/AssignmentResponse.java curriculumStartAt 필드 추가 및 생성자와 from 메서드 로직 업데이트

Assessment against linked issues

Objective Addressed Explanation
커리큘럼 시작일 필드 추가 (#752)

Poem

🐰 새로운 필드가 생겼네,
커리큘럼 시작일, 정말 기쁘네!
과제와 함께, 시간도 담아,
더 많은 정보로, 세상이 밝아!
달리자, 친구들아, 함께 가자,
새로운 변화에, 모두 환영해! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@uwoobeat uwoobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

github-actions bot commented Sep 4, 2024

Job Summary for Gradle

Check Style and Test to Develop :: build-test
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
gdsc check 8.5 Build Scan published

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6471966 and 4473518.

Files selected for processing (1)
  • src/main/java/com/gdschongik/gdsc/domain/study/dto/response/AssignmentResponse.java (3 hunks)
Additional comments not posted (4)
src/main/java/com/gdschongik/gdsc/domain/study/dto/response/AssignmentResponse.java (4)

8-8: LGTM!

LocalTime 타입을 사용하기 위해 필요한 import 문이 추가되었습니다.


17-17: LGTM!

assignmentStatus 필드가 @Schema 어노테이션과 함께 올바르게 추가되었습니다.


18-18: LGTM!

curriculumStartAt 필드가 @Schema 어노테이션과 함께 올바르게 추가되었습니다.


28-29: LGTM!

from 메서드에서 assignmentStatuscurriculumStartAt 필드의 값을 올바르게 설정하고 있습니다.

@Sangwook02 Sangwook02 merged commit bb700ff into develop Sep 4, 2024
1 check passed
@Sangwook02 Sangwook02 deleted the feature/752-add-curriculum-start-date-to-dto branch September 4, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssignmentResponse에 커리큘럼 시작일 필드 추가
2 participants