Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 과제 제출 컨벤션 소문자로 변경 #754

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

uwoobeat
Copy link
Member

@uwoobeat uwoobeat commented Sep 4, 2024

🌱 관련 이슈

📌 작업 내용 및 특이사항

📝 참고사항

📚 기타

Summary by CodeRabbit

  • 버그 수정
    • GitHub 과제 경로의 파일 확장자를 대문자에서 소문자로 변경하여 파일 접근 시의 일관성을 개선했습니다.
    • 제출 링크의 파일 이름을 대문자에서 소문자로 변경하여 명명 규칙을 일관되게 유지했습니다.

Copy link

coderabbitai bot commented Sep 4, 2024

Walkthrough

변경 사항은 GithubConstantStudyConstant 클래스의 상수 문자열에서 파일 이름의 확장자를 대문자에서 소문자로 변경하는 것입니다. 이 변경은 코드의 로직이나 기능에는 영향을 미치지 않으며, 단순히 일관성을 위한 수정입니다.

Changes

파일 경로 변경 요약
src/main/java/com/gdschongik/gdsc/global/common/constant/GithubConstant.java
src/test/java/com/gdschongik/gdsc/global/common/constant/StudyConstant.java
WIL.mdwil.md로 변경

Assessment against linked issues

Objective Addressed Explanation
과제 제출 컨벤션 소문자로 변경 (#731)

Poem

🐇
작은 토끼가 말하길,
"소문자로 바뀌었네,
WIL에서 wil로,
이제 더 깔끔하네!
파일이름이 반짝이네!"
🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@uwoobeat uwoobeat self-assigned this Sep 4, 2024
Copy link
Member

@Sangwook02 Sangwook02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

github-actions bot commented Sep 4, 2024

Job Summary for Gradle

Check Style and Test to Develop :: build-test
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
gdsc check 8.5 Build Scan published

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bb700ff and f1bdbbd.

Files selected for processing (2)
  • src/main/java/com/gdschongik/gdsc/global/common/constant/GithubConstant.java (1 hunks)
  • src/test/java/com/gdschongik/gdsc/global/common/constant/StudyConstant.java (1 hunks)
Files skipped from review due to trivial changes (2)
  • src/main/java/com/gdschongik/gdsc/global/common/constant/GithubConstant.java
  • src/test/java/com/gdschongik/gdsc/global/common/constant/StudyConstant.java

@uwoobeat uwoobeat merged commit aee0968 into develop Sep 4, 2024
1 check passed
@uwoobeat uwoobeat deleted the feature/731-wil-lowercase branch September 4, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ 과제 제출 컨벤션 소문자로 변경
2 participants