-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Sentry 필터링 적용 #777
Merged
Merged
chore: Sentry 필터링 적용 #777
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
12 changes: 12 additions & 0 deletions
12
src/main/java/com/gdschongik/gdsc/global/common/constant/SentryConstant.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
package com.gdschongik.gdsc.global.common.constant; | ||
|
||
import java.util.List; | ||
|
||
public class SentryConstant { | ||
|
||
private SentryConstant() {} | ||
|
||
public static final String ACTUATOR_KEYWORD = "actuator"; | ||
|
||
public static final List<String> KEYWORDS_TO_IGNORE = List.of(ACTUATOR_KEYWORD); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
src/main/java/com/gdschongik/gdsc/infra/sentry/CustomBeforeSendTransactionCallback.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
package com.gdschongik.gdsc.infra.sentry; | ||
|
||
import static com.gdschongik.gdsc.global.common.constant.SentryConstant.*; | ||
|
||
import io.sentry.Hint; | ||
import io.sentry.SentryOptions; | ||
import io.sentry.protocol.SentryTransaction; | ||
import org.jetbrains.annotations.NotNull; | ||
import org.springframework.stereotype.Component; | ||
|
||
@Component | ||
public class CustomBeforeSendTransactionCallback implements SentryOptions.BeforeSendTransactionCallback { | ||
|
||
@Override | ||
public SentryTransaction execute(@NotNull SentryTransaction transaction, @NotNull Hint hint) { | ||
String transactionEndpoint = transaction.getTransaction(); | ||
|
||
if (transactionEndpoint == null) { | ||
return transaction; | ||
} | ||
|
||
if (KEYWORDS_TO_IGNORE.stream().anyMatch(transactionEndpoint::contains)) { | ||
return null; | ||
} | ||
|
||
return transaction; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
올바른 예외 클래스 사용 필요
NoResourceFoundException
클래스는 존재하지 않을 수 있습니다. Spring MVC에서는 존재하지 않는 엔드포인트에 대한 예외로NoHandlerFoundException
을 사용합니다. 이 클래스로 수정하는 것을 권장합니다.수정 사항 제안:
예외 목록에서의 변경:
Committable suggestion