Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a responsive event detail hero page #34

Closed
wants to merge 10 commits into from

Conversation

lokesh-wagh
Copy link

fixes #9

@netlify
Copy link

netlify bot commented Oct 6, 2023

Deploy Preview for upes-gdsc ready!

Name Link
🔨 Latest commit 7949fd5
🔍 Latest deploy log https://app.netlify.com/sites/upes-gdsc/deploys/652255de2139c6000904d740
😎 Deploy Preview https://deploy-preview-34--upes-gdsc.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85
Accessibility: 84
Best Practices: 100
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@lokesh-wagh
Copy link
Author

image
build has been successful locally

don't know why it is causing issue's

@rohin079
Copy link
Member

rohin079 commented Oct 7, 2023

@lokesh-wagh Kindly look at the build preview logs to find out why the build is failing, correct it and then try to raise another commit until all checks are passed

@lokesh-wagh
Copy link
Author

hey the build issue's are resolved can you merge it now

@rohin079
Copy link
Member

rohin079 commented Oct 7, 2023

@lokesh-wagh the css of the homepage has been changed due to which its UI is looking different :

image

kindly update that to make it look like this again:

image

@lokesh-wagh
Copy link
Author

hey !!

i have fixed the UI issue

@rohin079
Copy link
Member

rohin079 commented Oct 8, 2023

@lokesh-wagh The dark theme button is still left, other than that, great work! Commit that and i'll close the issue as completed

@lokesh-wagh
Copy link
Author

Can you elaborate what i am supposed to do with the dark themed button

@rohin079
Copy link
Member

rohin079 commented Oct 8, 2023

Can you elaborate what i am supposed to do with the dark themed button

The alignment of the dark theme button has been changed ( refer to the ss) and its animation has stopped working w your commit, fix that to how it were before you added your changes: https://upes-gdsc.netlify.app/ Look at the dark theme button on this page at top right

@rohin079
Copy link
Member

rohin079 commented Oct 9, 2023

@lokesh-wagh Any updates?

@lokesh-wagh
Copy link
Author

Hey!!

Can i get some more time to fix this minor issue
Actually i have a techfest to compete in at my college

@rohin079
Copy link
Member

rohin079 commented Oct 9, 2023

@lokesh-wagh Sure, no issues :)

@rohin079
Copy link
Member

@lokesh-wagh Any updates?

@lokesh-wagh
Copy link
Author

Hey !!
I am closing this PR since i need to prepare for ICPC
sry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants