Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced shape based painter example #710

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ddabrahim
Copy link
Contributor

@ddabrahim ddabrahim commented Sep 28, 2024

Updated the example to comply with latest guidelines

Replaced number variables with boolean variables where it was reasonable to do so
Made sure all variables declared in the variables editor
Added extra comments and events groups to make it more simple to follow how the example works
Added RGBA letters to color selection lines.

Project was corrupted and didn't worked in the web editor, it was working in the desktop editor due to pure luck I think. what I have done to fix it:

Variable types in the variable editor was wrong
Replaced old variable events with the new variable events
Some variable expressions were also wrong, was calling a number variable when it was a string variable (RGBA).
Changed object names to remove errors regarding being the same as variable names.

Replaced number variables with boolean variables where it was reasonable and made sure the variables are added to variables editor. Also updated comments to reflect this
Added extra comments and event groups to make it more simple to see through how the example works.
Added RGBA text to color selection lines
@ddabrahim
Copy link
Contributor Author

It seems if previewed inside the web editor, the RGB color selection does not work. But if previewed inside the desktop version and if I exported to local HTML5, it works. Not sure why it doesn't work inside the web editor.

@ddabrahim
Copy link
Contributor Author

I think I've found the problem. It seems the project is corrupted and the fact it is working on the desktop is pure luck. I managed to find a fix in the web editor, I am going to attempt to implement the fix on the desktop now and see if it also fixes it in the web editor

Variable types in variable editors was wrong, variable expressions in some events were also wrong and replaced all legacy variable events with the new universal variable event. Rounded the Value of BarSelect, it seemed float value can not be used as color
@ddabrahim
Copy link
Contributor Author

ddabrahim commented Sep 29, 2024

I can confirm that the project is fixed and working as expected in both the web editor and the desktop editor now.
What I have done was:

Variable types in the variable editor was wrong
Replaced old variable events with the new variable events
Some variable expressions were also wrong, was calling a number variable when it was a string variable (RGBA).
Changed object names to remove errors regarding being the same as variable names.

I am uncertain why is the build test fail however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant