[Feat] #21 - 공통 버튼 구현 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seongmin221
reviewed
Jul 9, 2023
| case signIn = "회원가입" | ||
| case next = "다음" | ||
| case confirm = "확인" | ||
| case duplicate = "중복 확인" |
There was a problem hiding this comment.
P1:
"중복확인" 으로 변경 부탁드려요 !
띄어쓰기가 없어야 하는 것 같숩니다 !
seongmin221
reviewed
Jul 9, 2023
Comment on lines
42
to
45
| private func setUI() { | ||
| makeCornerRound(radius: 11) | ||
| titleLabel?.font = .pretendardMedium(18) | ||
| } |
There was a problem hiding this comment.
Q:
훔 제가 then 을 처음 써봐서 어느 상황에서는 property.do { ~~ } 를 쓸지,
어느 상황에서 property.font 이런식으로 쓸지 모르겠어서 그냥 다 전자로 통일시키긴 했거든요 ... ??
혹시 이에 대한 기준이 있을까여 ..??
seongmin221
reviewed
Jul 9, 2023
Comment on lines
47
to
74
| func setButtonTitle(_ title: ButtonTitle) { | ||
| setTitle(title.rawValue, for: .normal) | ||
| } | ||
|
|
||
| func setButtonUI(_ color: UIColor, _ border: UIColor? = .clear) { | ||
| self.backgroundColor = color | ||
|
|
||
| switch color { | ||
| case .gbbMain3!, .gbbGray700!: setTitleColor(.gbbGray100, for: .normal) | ||
| case .gbbMain2!: setTitleColor(.white, for: .normal) | ||
| default: | ||
| setTitleColor(.gbbGray400, for: .normal) | ||
| } | ||
|
|
||
| if let border = border { | ||
| makeBorder(width: 1, color: border) | ||
| if border != .clear { | ||
| setTitleColor(border, for: .normal) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func setAction(completion: ((UIAction) -> Void)? = nil) { | ||
| let action = UIAction { action in | ||
| completion?(action) | ||
| } | ||
| addAction(action, for: .touchUpInside) | ||
| } |
There was a problem hiding this comment.
Q:
훔... 요건 논의해보면 좋을 것 같은 부분인데,
(정말 개인적인 코드 스타일) 저는 init 또는 viewDidLoad 에 들어가는 함수들만 set 을 앞에 붙였거든요 !
그 외에 설정하는 함수들은 configure 를 앞에 붙이고 쓰고 있습니다 !
오늘부터 합숙 시작하니까, 논의해보면 좋을 것 같아요 !!
seongmin221
reviewed
Jul 9, 2023
Comment on lines
13
to
23
| enum ButtonTitle: String, CaseIterable { | ||
|
|
||
| case login = "로그인" | ||
| case signIn = "회원가입" | ||
| case next = "다음" | ||
| case confirm = "확인" | ||
| case duplicate = "중복 확인" | ||
| case write = "작성하기" | ||
| case start = "시작하기" | ||
|
|
||
| } |
There was a problem hiding this comment.
P2:
훔 근데 Strings.swift 파일에 지정해 두었는데 여기서 또 텍스트로 작성하신 이유가 있을까요 ??
없다면 Strings.swift 파일의 값들 삭제 부탁드립니다 !
seongmin221
reviewed
Jul 9, 2023
ckkim817
approved these changes
Jul 11, 2023
| private func setUI() { | ||
| self.do { | ||
| $0.makeCornerRound(radius: 11) | ||
| $0.titleLabel?.font = .pretendardMedium(18) |
There was a problem hiding this comment.
P1:
이거 텍스트 스타일 headLine으로 바꿔주세요~ (headLine 서체 pretendard medium으로 바꿔놓음)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌁 Background
📱 Screenshot
👩💻 Contents
✅ Testing
뷰컨트롤러에서 작업하시는 경우 아래와 같이 레이아웃을 잡으시면 됩니다!
📝 Review Note
📣 Related Issue
📬 Reference