Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] #277 - BubbleView Builder 구현 #278

Merged

Conversation

jeongdung-eo
Copy link
Contributor

@jeongdung-eo jeongdung-eo commented Jun 26, 2024

🌁 Background

  • 다양한 화면에서 bubble view가 사용이 되는데 객체의 재사용상과 가독성을 높이기 위해서 builder 패던으로 리팩토링했습니다.

📱 Screenshot

스크린샷 2024-07-19 14 59 51

👩‍💻 Contents

  • builder를 이용해서 left mode와 right mode를 구분하여 director로 구현했습니다.

✅ Testing

📝 Review Note

  • Bubble view는 필터 여부에 따라 표시 여부가 결정되어야 하지만, 아직 해당 부분은 구현되지 않았습니다. 클린 아키텍처를 적용하면서 이 로직을 수정하겠습니다!!

📣 Related Issue

📬 Reference

Copy link
Contributor

@seongmin221 seongmin221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조은것 같습니다ㅏ ~
PR 제목만 수정해주세요 ~~~

@jeongdung-eo jeongdung-eo self-assigned this Jul 19, 2024
@jeongdung-eo jeongdung-eo changed the title [Feat] 디자인 시스템에서 Builder Pattern을 사용해 BubbleView Builder와 Director 구현 [Feat] #277 - BubbleView Builder 구현 Jul 19, 2024
@jeongdung-eo jeongdung-eo merged commit 3f77c85 into refactoring/#253-design-system Jul 19, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants