-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] #31 - WriteReviewViewController 기능 완료 #38
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splash image, title icon 추가
splash image와 title을 launchscreen으로 묶고 icons 폴더로 옮겼습니다
1 -> 1.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌁 Background
리뷰 작성하기 UI 구현에 이어 기능도 구현 완료하였습니닷 !
다만 문제가 하나 있긴 한데... 일단은 얼추 되어서 후순위로 넣어두겠습니닷
📱 Screenshot
좋아요 눌렀을 시 플로우
Simulator.Screen.Recording.-.iPhone.13.mini.-.2023-07-11.at.18.00.51.mp4
별로'예'요 눌렀을 시 플로우
Simulator.Screen.Recording.-.iPhone.13.mini.-.2023-07-11.at.18.01.44.mp4
리뷰 자세히 작성할 때 플로우
Simulator.Screen.Recording.-.iPhone.13.mini.-.2023-07-11.at.18.22.19.mp4
👩💻 Contents
✅ Testing
넘어와서 테스트 ㄱㄱ
📝 Review Note
키보드 올라갈 때 TextView 하단에 몇 글자 썼는지 표시되는 부분도 보였으면 좋겠는데 그 부분은....후순위로...
그리고 약간의 버그가 있습니닷
좋아요나 별로예요 누르고 다른 하단 옵션들 눌렀을 설정하고, 다시 동일한 좋아요나 별로예요 눌렀을 시 설정한 옵션들이 사라집니닷.. 하핳
📣 Related Issue
📬 Reference