Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] #47 - 홈뷰 리뷰 키워드 컬렉션뷰 구현 #48

Merged
merged 9 commits into from
Jul 15, 2023

Conversation

jeongdung-eo
Copy link
Contributor

@jeongdung-eo jeongdung-eo commented Jul 13, 2023

🌁 Background

  • 홈 리뷰 키워드 컬렉션뷰를 위한 PR 입니다.

📱 Screenshot

홈

👩‍💻 Contents

  • 홈뷰 BEST 리뷰 컬렉션뷰 셀 안에 리뷰 키워드 컬렉션뷰를 구현했습니다.
  • 재사용 셀을 사용하였고, 서버에서 내려오는 값이 각 키워드에 대한 Bool 값이라서 리스트를 하나 선언해서 Bool 값에 따라서 리스트에 담아두었습니다.
  • 홈 섹션 헤더 텍스트 색상 변경했습니다.
  • 더미 데이터 부분은 수정 후 올리겠습니다.

✅ Testing

📝 Review Note

📣 Related Issue

📬 Reference

Copy link
Contributor

@seongmin221 seongmin221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제 생각엔 문제 없는 것 같아요 !! 고생 많으셨어요 :)

@jeongdung-eo jeongdung-eo merged commit 786cf5e into develop Jul 15, 2023
1 of 2 checks passed
@jeongdung-eo jeongdung-eo deleted the feat/#47-reviewKeyword branch September 25, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 홈뷰 리뷰 키워드 컬렉션뷰 구현
2 participants