Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saturation values above 1 #2691

Open
paveltomin opened this issue Sep 21, 2023 · 2 comments · May be fixed by #3443
Open

Saturation values above 1 #2691

paveltomin opened this issue Sep 21, 2023 · 2 comments · May be fixed by #3443
Assignees
@jafranc @dkachuma
Labels
type: feature New feature or request

Comments

@paveltomin
Copy link
Contributor

GEOS formulation allows saturation values to go above 1 (not sure about below zero).
The computed saturation values are used as is to compute rel perms that might be not really physical thing to do and also may mislead the solver blocking some flow or allowing too much flow.
More reasonable way would be to normalize saturation values used for rel perm computes, see, e.g., https://drive.google.com/open?id=10dHD58pO8dy5hSz4RjVo8m0Mjs6C0a69
@paveltomin paveltomin added the type: new A new issue has been created and requires attention label Sep 21, 2023
@castelletto1 castelletto1 added type: feature New feature or request and removed type: new A new issue has been created and requires attention labels Apr 1, 2024
@dkachuma
Copy link
Contributor

dkachuma commented Jun 6, 2024

Attaching small test case. The first nonlinear steps for this case show saturation changes of more than 1 indicating that (at least the intermediate) saturations are greater than 1.
caseFiles.tar.gz

@paveltomin
Copy link
Contributor Author

Should be addressed by new formulation in #3443

@paveltomin paveltomin linked a pull request Dec 5, 2024 that will close this issue
feat: Overall Composition (Z) Formulation #3443
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jafranc jafranc

@dkachuma dkachuma

Labels
type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Overall Composition (Z) Formulation GEOS-DEV/GEOS
5 participants
@paveltomin @francoishamon @castelletto1 @jafranc @dkachuma