Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Overall Composition (Z) Formulation #3443

Open
wants to merge 80 commits into
base: develop
Choose a base branch
from

Conversation

rasimHZ
Copy link
Contributor

@rasimHZ rasimHZ commented Nov 14, 2024

This feature adds a new molar formulation for compositional flow, whereby the primary unknowns are pressure and overall compositions (z_c) instead of pressure and component densities (rho_c). The volume balance is then honored strictly - total density rho_T is found as function of pressure and compositions.

@paveltomin paveltomin linked an issue Dec 5, 2024 that may be closed by this pull request
@paveltomin paveltomin marked this pull request as ready for review December 19, 2024 19:24
@paveltomin paveltomin added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Dec 19, 2024
@paveltomin
Copy link
Contributor

rebaseline is needed because of

********************************************************************************
Error: /Problem/Solvers/compflow
	Group has a child 'targetCompFracChangeInTimeStep' in the file to compare but not the baseline file.
********************************************************************************
********************************************************************************
Error: /Problem/Solvers/compflow
	Group has a child 'useZFormulation' in the file to compare but not the baseline file.
********************************************************************************
********************************************************************************
Error: /Problem/Solvers/compflow
	Group has a child 'minCompFrac' in the file to compare but not the baseline file.
********************************************************************************

@paveltomin paveltomin added the flag: requires rebaseline Requires rebaseline branch in integratedTests label Dec 20, 2024
@paveltomin
Copy link
Contributor

paveltomin commented Dec 20, 2024

@dkachuma @tjb-ltk @CusiniM this is ready to have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saturation values above 1
3 participants