-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Temperature dependent Thermal Expansion Coefficient #3185
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3185 +/- ##
===========================================
+ Coverage 56.79% 57.17% +0.37%
===========================================
Files 1076 1081 +5
Lines 95739 95889 +150
===========================================
+ Hits 54375 54820 +445
+ Misses 41364 41069 -295 ☔ View full report in Codecov by Sentry. |
5fe7e2f
to
f9c5e54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, Sy Tuan.
LvArray::tensorOps::symAddIdentity< 3 >( totalStress, thermalStressIncrement ); | ||
|
||
// Save rock stress including the contribution of temperature change. | ||
m_solidUpdate.saveStress( k, q, totalStress ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change for computing effective stress to include thermal component.
Hello @rrsettgast and @CusiniM, this PR is almost ready for merge and would appreciate if you take a final review. |
This failure is always reported for
The problem is being handled by #3387 |
This PR implement the non-linear Thermo-Elastic behavior related to non constant Thermal Expansion Coefficient (TEC). Either a linear law or a table could be considered for defining TEC vs Temperature.