Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove NoOpFunc duplicates #3370

Open
wants to merge 5 commits into
base: pt/flow-kernels-folder
Choose a base branch
from
Open

refactor: Remove NoOpFunc duplicates #3370

wants to merge 5 commits into from

Conversation

paveltomin
Copy link
Contributor

@paveltomin paveltomin commented Sep 25, 2024 •
edited
Loading

needs to go after #3369

@paveltomin paveltomin self-assigned this Sep 25, 2024
CusiniM
CusiniM approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@CusiniM CusiniM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish that those things in codingUtilities were in their own namespace instead of being defined directly inside the geos one but the PR looks good to me.

@paveltomin paveltomin added type: cleanup / refactor Non-functional change (NFC) ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI and removed flag: ready for review labels Sep 26, 2024
@paveltomin paveltomin added the flag: no rebaseline Does not require rebaseline label Sep 26, 2024
@paveltomin paveltomin removed ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrsettgast rrsettgast rrsettgast approved these changes

@CusiniM CusiniM CusiniM approved these changes

@castelletto1 castelletto1 Awaiting requested review from castelletto1 castelletto1 is a code owner

@klevzoff klevzoff Awaiting requested review from klevzoff klevzoff is a code owner

@francoishamon francoishamon Awaiting requested review from francoishamon francoishamon is a code owner

Assignees

@paveltomin paveltomin

Labels
flag: no rebaseline Does not require rebaseline type: cleanup / refactor Non-functional change (NFC)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paveltomin @rrsettgast @CusiniM