Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable fully coupled mode for CompositionalMultiphaseReservoirPoromechanics and SinglePhaseReservoirPoromechanics #3388

Open
wants to merge 7 commits into
base: pt/set-mgr-strategy
Choose a base branch
from
Open

feat: Enable fully coupled mode for CompositionalMultiphaseReservoirPoromechanics and SinglePhaseReservoirPoromechanics #3388

wants to merge 7 commits into from

Conversation

paveltomin
Copy link
Contributor

should go after #3383 and #3386

  • works equivalent to MultiphasePoromechanicsReservoir and SinglePhasePoromechanicsReservoir, just more convenient to switch between FIM and SEQ within the same solver
  • can use the same MGR recipe (order of block is actually the same: mechanics, flow, wells)

@paveltomin paveltomin self-assigned this Oct 4, 2024
@paveltomin paveltomin changed the base branch from develop to pt/set-mgr-strategy October 4, 2024 22:15
@paveltomin
Copy link
Contributor Author

need review please

@CusiniM
Copy link
Collaborator

CusiniM commented Oct 14, 2024

I am lost. What are these? What s the difference between these and MultiphasePoromechanicsReservoir and SinglePhasePoromechanicsReservoir ?

@paveltomin
Copy link
Contributor Author

I am lost. What are these? What s the difference between these and MultiphasePoromechanicsReservoir and SinglePhasePoromechanicsReservoir ?

CompositionalMultiphaseReservoirPoromechanics and SinglePhaseReservoirPoromechanics were created for sequential since MultiphasePoromechanicsReservoir and SinglePhasePoromechanicsReservoir are designed differently: they are flow/mech + wells so when one runs them in sequential they will do flow/mech solve and wells solve iteratively.
CompositionalMultiphaseReservoirPoromechanics and SinglePhaseReservoirPoromechanics were not be able to run in FIM mode which is addressed in this PR.
I know this is confusing and ultimately we should clean this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasimHZ rasimHZ Awaiting requested review from rasimHZ

@jhuang2601 jhuang2601 Awaiting requested review from jhuang2601

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

@castelletto1 castelletto1 Awaiting requested review from castelletto1 castelletto1 is a code owner

@CusiniM CusiniM Awaiting requested review from CusiniM CusiniM is a code owner

Assignees

@paveltomin paveltomin

Labels
flag: ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paveltomin @CusiniM