Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix misuse of CommID #3402

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: Fix misuse of CommID #3402

merged 1 commit into from
Oct 17, 2024

Conversation

rrsettgast
Copy link
Member

At some point in the past a developer who will remain unnamed made it so that MPI_iCommData could be passed a CommID which was copied in MPI_iCommData. This allows for the case where the CommID is destroyed, and the MPI_iCommData would refer to a value of CommID that has been put back into the set of available CommID. Recall that no two communications can use the same CommID. This PR makes it a one-to-one relationship by grabbing the CommID inside of the constructor of MPI_iCommData as was the case before the unnamed developer changed it. Don't go looking for the culprit....I assure you he is quite remorseful for his blunder 😁

@rrsettgast rrsettgast added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Oct 16, 2024
@rrsettgast rrsettgast self-assigned this Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.

Project coverage is 56.47%. Comparing base (968476f) to head (01deaf0).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...hysicsSolvers/solidMechanics/SolidMechanicsMPM.cpp 0.00% 3 Missing ⚠️
...ration/EmbeddedSurfacesParallelSynchronization.cpp 0.00% 3 Missing ⚠️
...lvers/surfaceGeneration/ParallelTopologyChange.cpp 0.00% 2 Missing ⚠️
...ers/solidMechanics/SolidMechanicsLagrangianFEM.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3402      +/-   ##
===========================================
- Coverage    56.48%   56.47%   -0.01%     
===========================================
  Files         1074     1074              
  Lines        90502    90504       +2     
===========================================
  Hits         51116    51116              
- Misses       39386    39388       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rrsettgast rrsettgast merged commit 263e5fd into develop Oct 17, 2024
24 of 25 checks passed
@rrsettgast rrsettgast deleted the bugfix/commIdMisuse branch October 17, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants