Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Regex validation bugfix & unit test #3403

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Conversation

MelReyCG
Copy link
Contributor

This regex validation bugfix fix cover the case where a regex could validate a substring of a given valid string.
As an exemple, the generated enum regex None|Default|Value|Value2, while validating Value2, can validate Value, and wrongly produced the following error:

Input string validation failed at:
  "Value2"
        ^
Expected format: Input value must be one of { None, Default, Value, Value2 }.

Thanks @paveltomin for finding it!

@MelReyCG MelReyCG self-assigned this Oct 17, 2024
@MelReyCG MelReyCG added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Oct 17, 2024
@MelReyCG MelReyCG changed the title Regex validation bugfix & unit test Bugfix: Regex validation bugfix & unit test Oct 17, 2024
@MelReyCG MelReyCG changed the title Bugfix: Regex validation bugfix & unit test bugfix: Regex validation bugfix & unit test Oct 17, 2024
@MelReyCG MelReyCG changed the title bugfix: Regex validation bugfix & unit test fix: Regex validation bugfix & unit test Oct 17, 2024
@paveltomin paveltomin added ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: no rebaseline Does not require rebaseline ci: run code coverage enables running of the code coverage CI jobs labels Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.79%. Comparing base (7eee999) to head (fe2a95b).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3403   +/-   ##
========================================
  Coverage    56.79%   56.79%           
========================================
  Files         1076     1076           
  Lines        95743    95749    +6     
========================================
+ Hits         54377    54383    +6     
  Misses       41366    41366           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltomin paveltomin merged commit b43e001 into develop Oct 18, 2024
25 checks passed
@paveltomin paveltomin deleted the bugfix/rey/enumValidation branch October 18, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants