fix: use mass and energy consistently for single phase solvers #3485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paveltomin
changed the title
paveltomin
commented
Dec 9, 2024
| @@ -241,46 +241,38 @@ DECLARE_FIELD( temperatureScalingFactor, | |||
| NO_WRITE, | |||
| "Scaling factors for temperature" ); | |||
|
|
|||
| DECLARE_FIELD( mass, | |||
There was a problem hiding this comment.
mass went to single phase file since it is used there, not for compositional
paveltomin
commented
Dec 9, 2024
| @@ -594,8 +634,6 @@ void SinglePhaseBase::initializeFluidState( MeshLevel & mesh, arrayView1d< strin | |||
|
|
|||
| // 2. save the initial density (for use in the single-phase poromechanics solver to compute the deltaBodyForce) | |||
| fluid.initializeState(); | |||
|
|
|||
| updateMass( subRegion ); | |||
There was a problem hiding this comment.
this call is redundant, updateMass already called in updateFluidState few lines above
paveltomin
commented
Dec 9, 2024
| @@ -291,13 +260,11 @@ class SurfaceElementAccumulationKernel : public AccumulationKernel< SurfaceEleme | |||
| void computeAccumulation( localIndex const ei, | |||
| Base::StackVariables & stack ) const | |||
| { | |||
| Base::computeAccumulation( ei, stack, [&] () | |||
| Base::computeAccumulation( ei, stack ); | |||
paveltomin
commented
Dec 9, 2024
| stack.dSolidEnergy_dPres = dSolidVolume_dPres * m_rockInternalEnergy[ei][0]; | ||
| stack.dSolidEnergy_dTemp = solidVolume * m_dRockInternalEnergy_dTemp[ei][0] + dSolidVolume_dTemp * m_rockInternalEnergy[ei][0]; | ||
| } | ||
| {}; |
There was a problem hiding this comment.
i could not remove this, somehow compiler gets always confused
paveltomin
added
type: cleanup / refactor
paveltomin
requested review from
rrsettgast,
CusiniM,
castelletto1,
frankfeifan,
ryar9534 and
jhuang2601
as code owners
added 4 commits
December 9, 2024 13:34
|
you may want to keep an eye on this: #3460 |
Yes thanks |
paveltomin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unified where possible
for poromechanics - hard to do because porosity is being updated inside the assembly kernel, so left it as is
fixed glitch with double porosity update in poromechanics when it was updated both in flow solver and in poromechanics kernel using different equations leading to potential inconsistencies