-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: clarify new gravity, clean up kernel flags usage, move CFL computations to FVM solver #3486
Open
paveltomin
wants to merge
11
commits into
develop
Choose a base branch
from
pt/clarify-new-gravity
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paveltomin
commented
Dec 9, 2024
•
edited
Loading
edited
- clarify new gravity as requested here fix: make new gravity treatment from #3337 an option #3467 (comment)
- clean up kernel flags usage in flow solver to avoid bugs: the basic idea is to set the flags outside of kernels create and launch to avoid mismatch between different version (isothermal/thermal etc) when one flag is set here but is missing there
- move CFL computations to FVM solver where it belongs
@paveltomin Yes. this is what i meant. Could you:
|
…GEOS into pt/clarify-new-gravity
paveltomin
requested review from
CusiniM,
ryar9534 and
castelletto1
as code owners
December 9, 2024 16:59
paveltomin
added
flag: ready for review
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
labels
Dec 9, 2024
done, please have a look |
paveltomin
added
flag: requires rebaseline
Requires rebaseline branch in integratedTests
and removed
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
labels
Dec 9, 2024
new rebaselines needed:
|
@rrsettgast is it good enough? |
paveltomin
changed the title
refactor: clarify new gravity
refactor: clarify new gravity, clean up kernel flags usage in flow solver to avoid bugs, move CFL computations to FVM solver
Dec 20, 2024
paveltomin
added
the
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
label
Dec 20, 2024
paveltomin
changed the title
refactor: clarify new gravity, clean up kernel flags usage in flow solver to avoid bugs, move CFL computations to FVM solver
refactor: clarify new gravity, clean up kernel flags usage, move CFL computations to FVM solver
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
flag: ready for review
flag: requires rebaseline
Requires rebaseline branch in integratedTests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.