fix: Feature/byer3/mass inj constraint fix #3495
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjb-ltk
requested review from
CusiniM,
paveltomin,
ryar9534 and
dkachuma
as code owners
paveltomin
reviewed
Dec 17, 2024
src/coreComponents/physicsSolvers/fluidFlow/wells/CompositionalMultiphaseWell.cpp
Outdated
Show resolved
Hide resolved
paveltomin
approved these changes
Dec 17, 2024
tjb-ltk
changed the title
tjb-ltk
added
flag: requires rebaseline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing logic to support switching from fixed mass rate injection rate constraint to max injection pressure. The code will crash if running a model where this condition is encountered. No issues with mass injection constraint in scenarios where pressure associated with injection rate is less than maximum injection pressure. 2 test cases added to demonstrate constraint switching using mass injection rate constraint and total injection rate tables. The cases should produce nearly identical results.