Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix to RAJA build options #283

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add prefix to RAJA build options #283

wants to merge 7 commits into from

Conversation

victorapm
Copy link
Contributor

Add RAJA_ prefix to CMake build options for RAJA as the current format on master is not being recognized

@victorapm victorapm self-assigned this Sep 10, 2024
@rrsettgast
Copy link
Member

@victorapm can you create a GEOS PR to test this?

@victorapm
Copy link
Contributor Author

Yes, I can do that.

I just realized this:

set(SUPERLU_URL "${TPL_MIRROR_DIR}/superlu_dist-0f6efc3.tar.gz")

which is a couple of years old. Should we update to a newer superlu-dist?

@castelletto1
Copy link
Contributor

castelletto1 commented Sep 12, 2024

Yes, I can do that.

I just realized this:

set(SUPERLU_URL "${TPL_MIRROR_DIR}/superlu_dist-0f6efc3.tar.gz")

which is a couple of years old. Should we update to a newer superlu-dist?

Yes, let's update to the latest release

@rrsettgast
Copy link
Member

@victorapm The update of superLU may be problematic. I suggest you split this PR to just update the raja build options and we do the superlu in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants