Build shared before linting

GMOD · Jul 20, 2023 · 3541c3b · 3541c3b
1 parent 0156fe7
commit 3541c3b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml
@@ -16,6 +16,11 @@ jobs:
           cache: yarn
       - name: Install
         run: yarn --immutable
+        # Have to build shared before linting so type-based lint rules can
+        # run correctly
+      - name: Build shared
+        run: yarn build
+        working-directory: packages/apollo-shared
       - name: Lint codebase
         run: yarn eslint --report-unused-disable-directives --max-warnings 0 --ext .js,.ts,.jsx,.tsx .
       - name: Test codebase

diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml
@@ -16,11 +16,13 @@ jobs:
           cache: yarn
       - name: Install
         run: yarn --immutable
-      - name: Lint codebase
-        run: yarn eslint --ext .js,.ts,.jsx,.tsx .
+        # Have to build shared before linting so type-based lint rules can
+        # run correctly
       - name: Build shared
         run: yarn build
         working-directory: packages/apollo-shared
+      - name: Lint codebase
+        run: yarn eslint --ext .js,.ts,.jsx,.tsx .
       - name: Build collaboration server
         run: yarn build
         working-directory: packages/apollo-collaboration-server