Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test files to eslint using specialized tsconfig #145

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

cmdcolin
Copy link
Contributor

This issue is a little obscure but recent changes to this package changed the eslint config to use @typescript-eslint, and the eslint parser needs a tsconfig. However, the tsconfig only refers to the src directory. This PR keeps the current setup of tsconfig.json to only include "src" but has a special tsconfig.lint.json that includes the "test" directory. This allows the eslint to run over the test directory, but only makes it so that the build process outputs the src directory. Is test is included in the tsconfig.json, then nested subdirectories are outputted in dist for both src and test

@cmdcolin
Copy link
Contributor Author

This same pattern may be able to be added to other parser packages

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b418271) 88.06% compared to head (ed773f2) 88.06%.

❗ Current head ed773f2 differs from pull request most recent head 39339e6. Consider uploading reports for the commit 39339e6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   88.06%   88.06%           
=======================================
  Files           7        7           
  Lines         578      578           
  Branches      144      144           
=======================================
  Hits          509      509           
  Misses         69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmdcolin cmdcolin merged commit e9edde4 into master Jan 25, 2024
1 check passed
@cmdcolin cmdcolin deleted the add_test_lint branch January 25, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant