Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Schema as a newtype around serde_json::Value #289

Merged
merged 10 commits into from
May 12, 2024
Merged

Conversation

GREsau
Copy link
Owner

@GREsau GREsau commented May 11, 2024

Implements #242

Still to do (not necessarily all as part of this PR):

  • Fix JsonSchema implementations for types in third-party crates
  • Remove now-unnecessary preserve_order feature flag
  • Where we currently use a single-valued enum, instead use const (check which schema versions support const - may require a new visitor to change const to enum)
  • Fix deriving JsonSchema on large types, ensure compile times are OK
  • Reduce usages of json!/json_schema! for better performance, particularly in schemars_derive
  • Review doc comments
  • Update doctests (causing CI to fail)

@GREsau GREsau merged commit 342cd5f into v1 May 12, 2024
8 checks passed
@GREsau GREsau deleted the schema-as-value-newtype branch May 12, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant