Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature for serde_bytes::ByteBuf #349

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ratmice
Copy link

@ratmice ratmice commented Nov 7, 2024

Rebasing PR #252 on top of master, because the original PR wasn't made from a feature branch, it was easier to just open a new PR (and there was no substantial discussion lost).

Although it has been a while, I'm still interested in this patch for use in the linebender peniko crate.
Other linebender crates (kurbo) support schemars, but serde_bytes support is needed for peniko.
Supporting it there would currently allow some cleanups to CI in linebender/vello#733

serde_bytes being a dtolnay making it somewhat part of the serde ecosystem so at least from my perspective
this is a good argument for supporting the crate.

@ratmice
Copy link
Author

ratmice commented Nov 7, 2024

I'll be honest I'm a little bit confused by the ci setup for this crate.
While I see many testsuite failures running e.g. cargo test,
I don't actually see the ones listed in the unsuccessful checks here when running locally.

@ratmice
Copy link
Author

ratmice commented Nov 7, 2024

Probably going to take me a bit of time to go through all the changes in #340 to figure out what needs to be done to replace test_default_generated_schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant