π :: μλΉμ€ μμ μ μμ μ€ μ¬νμ κ²μ¦ λ‘μ§ #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KimTaeO
reviewed
Mar 8, 2024
| @@ -33,6 +36,9 @@ class DelegateOwnerService( | |||
| val delegateUser = userRepository.findByIdOrNull(delegateUserId) | |||
| ?: throw UserNotFoundException() | |||
|
|
|||
| if (delegateUser.userRole.any { it.userRoleType != UserRoleType.ROLE_STUDENT }) | |||
| throw NotValidDelegateUserException() | |||
There was a problem hiding this comment.
μ NotValid보λ€λ InvalidλΌλ λ¨μ΄λ₯Ό μ¬μ©νλ©΄ μ’μ κ² κ°λ€μ
There was a problem hiding this comment.
e7d4bff
μμ νμμ΅λλ€
| import com.msg.gauth.global.exception.ErrorCode | ||
| import com.msg.gauth.global.exception.exceptions.BasicException | ||
|
|
||
| class NotValidDelegateUserException: BasicException(ErrorCode.BAD_REQUEST) |
There was a problem hiding this comment.
ErrorCodeμ BAD_REQUESTλ₯Ό μ¬μ©ν기보λ€λ μ νν λ©μμ§λ₯Ό λ¨κΈΈ μ μλκ±Έ ErrorCode enumμ μλ‘ μΆκ°ν΄μ£ΌμΈμ
There was a problem hiding this comment.
fab0e47
μΆκ°νμμ΅λλ€ νμΈλΆνλλ €μ
KimTaeO
approved these changes
Mar 8, 2024
Umjiseung
deleted the
283-feat/service-owner-transfer-during-student-verification-logic-added
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π‘ κ°μ
μλΉμ€ μμ μ μμνλ μ€μ μμμκ° μ¬νμμΈμ§ κ²μ¦νλ λ‘μ§μ μΆκ°νμ΅λλ€.
π μμ λ΄μ©
π λ³κ²½μ¬ν
πββοΈ μ§λ¬Έμ¬ν
βοΈ μ¬μ©λ²
πΈ κΈ°ν