๐ :: ๋น๋ฐ๋ฒํธ ์ฌ์ค์ ๊ธฐ๋ฅ ์ถ๊ฐ #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Umjiseung
added
1๏ธโฃPriority: High
KimTaeO
reviewed
Mar 13, 2024
Comment on lines
15
to
28
| fun toEntity(user: User, encodedPassword: String): User = | ||
| User( | ||
| id = user.id, | ||
| email = user.email, | ||
| password = encodedPassword, | ||
| gender = user.gender, | ||
| name = user.name, | ||
| grade = user.grade, | ||
| classNum = user.classNum, | ||
| num = user.num, | ||
| roles = user.roles, | ||
| state = user.state, | ||
| profileUrl = user.profileUrl | ||
| ) |
There was a problem hiding this comment.
toEntity ๊ตณ์ด ์ ์ฐ๊ณ ์๋น์ค ์ฝ๋์์ named argument๋ก ์ ์ธํ๋ฉด ๋ ๊ฒ ๊ฐ์์
There was a problem hiding this comment.
8c78e9c
toEntity๋ฅผ ์ญ์ ํ์ต๋๋ค
| throw PasswordMismatchException() | ||
| } | ||
|
|
||
| userRepository.save(passwordUpdateRequestDto.toEntity(currentUser, passwordEncoder.encode(passwordUpdateRequestDto.newPassword))) |
There was a problem hiding this comment.
passwordUpdateRequestDto.toEntity(currentUser, passwordEncoder.encode(passwordUpdateRequestDto.newPassword))๋ ๊ฐ์์ฑ์ด ๋๋ฌด ๋จ์ด์ง๋ ๊ฒ ๊ฐ๋ค์ ๋ณ์์ ํ๋ฒ ๋ด์์ ๋ณด๊ธฐ ์ข๊ฒ ์์ ํด์ฃผ์ธ์
| @@ -16,7 +16,7 @@ class User( | |||
| val email: String, | |||
|
|
|||
| @field:Size(max = 60) | |||
| val password: String, | |||
| var password: String, | |||
There was a problem hiding this comment.
var๋ก ๋ฐ๊ฟ ํ์ ์์ ๊ฒ ๊ฐ์์
There was a problem hiding this comment.
48dbf41
์์ ํ์์ต๋๋ค
KimTaeO
approved these changes
Mar 13, 2024
baekteun
reviewed
Mar 13, 2024
src/main/kotlin/com/msg/gauth/domain/auth/service/UpdatePasswordService.kt
Outdated
Show resolved
Hide resolved
baekteun
reviewed
Mar 13, 2024
src/main/kotlin/com/msg/gauth/domain/auth/service/UpdatePasswordService.kt
Outdated
Show resolved
Hide resolved
baekteun
reviewed
Mar 13, 2024
src/main/kotlin/com/msg/gauth/global/security/SecurityConfig.kt
Outdated
Show resolved
Hide resolved
baekteun
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ก ๊ฐ์
๋ฑ๋ก๋ ๋น๋ฐ๋ฒํธ๋ฅผ ์ฌ์ค์ ํ๋ ๊ธฐ๋ฅ์ ์ถ๊ฐํ์์ต๋๋ค.
๐ ์์ ๋ด์ฉ
๐ ๋ณ๊ฒฝ์ฌํญ
๐โโ๏ธ ์ง๋ฌธ์ฌํญ
โ๏ธ ์ฌ์ฉ๋ฒ
๐ธ ๊ธฐํ