Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: ๋ณ€๊ฒฝ ์‹œ ๋ฆฌ์†Œ์Šค์„œ๋ฒ„ ๋ฐ˜์˜ ํ™•์ธ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ์ถ”๊ฐ€ #311

Merged
merged 1 commit into from
Apr 8, 2024
Merged

๐Ÿ”€ :: ๋ณ€๊ฒฝ ์‹œ ๋ฆฌ์†Œ์Šค์„œ๋ฒ„ ๋ฐ˜์˜ ํ™•์ธ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ์ถ”๊ฐ€ #311

merged 1 commit into from
Apr 8, 2024

Conversation

KimTaeO
Copy link
Contributor

@KimTaeO KimTaeO commented Apr 8, 2024 •
edited
Loading

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

์ฝ”๋“œ ๋ณ€๊ฒฝ ์‹œ ๋ฆฌ์†Œ์Šค ์„œ๋ฒ„์™€ ์ฐจ์ด์ ์ด ์ƒ๊ฒจ ์˜ค๋ฅ˜๊ฐ€ ๋ฐœ์ƒํ•  ์šฐ๋ ค๊ฐ€ ์žˆ์—ˆ์Šต๋‹ˆ๋‹ค

Resolves: #{310}

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

PR Template checklist์— ๋ฆฌ์†Œ์Šค ์„œ๋ฒ„์— ๋ณ€๊ฒฝ์‚ฌํ•ญ ๋ฐ˜์˜ ์—ฌ๋ถ€ ์ถ”๊ฐ€

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. .env, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "ํ™˜๊ฒฝ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@KimTaeO KimTaeO added 0๏ธโƒฃPriority: Critical ์šฐ์„ ์ˆœ์œ„ ๊ธด๊ธ‰ โš™ Setting ๊ฐœ๋ฐœ ํ™˜๊ฒฝ ์„ธํŒ… labels Apr 8, 2024
@KimTaeO KimTaeO self-assigned this Apr 8, 2024
@KimTaeO KimTaeO linked an issue Apr 8, 2024 that may be closed by this pull request
GAuth PR templae ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ณ€๊ฒฝ #310
Closed
@KimTaeO KimTaeO merged commit 8f95bf7 into main Apr 8, 2024
1 check passed
@KimTaeO KimTaeO deleted the 310-update/gauth-pr-template-checklist branch April 8, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Umjiseung Umjiseung Umjiseung approved these changes

@dolong2 dolong2 Awaiting requested review from dolong2 dolong2 is a code owner

@baekteun baekteun Awaiting requested review from baekteun baekteun is a code owner

Assignees

@KimTaeO KimTaeO

Labels
0๏ธโƒฃPriority: Critical ์šฐ์„ ์ˆœ์œ„ ๊ธด๊ธ‰ โš™ Setting ๊ฐœ๋ฐœ ํ™˜๊ฒฝ ์„ธํŒ…
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GAuth PR templae ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ณ€๊ฒฝ
2 participants
@KimTaeO @Umjiseung