Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: cors url μΆ”κ°€ #313

Merged
merged 1 commit into from
Apr 12, 2024
Merged

πŸ”€ :: cors url μΆ”κ°€ #313

merged 1 commit into from
Apr 12, 2024

Conversation

Umjiseung
Copy link
Contributor

πŸ’‘ λ°°κ²½ 및 κ°œμš”

PR을 ν•˜κ²Œ 된 λ¬Έμ œμƒν™©, λ°°κ²½ 및 κ°œμš”μ— λŒ€ν•΄μ„œ μž‘μ„±ν•΄μ£Όμ„Έμš”!
ν”„λ‘ νŠΈμ˜ 버셀 url을 cors에 μΆ”κ°€ν•˜μ˜€μŠ΅λ‹ˆλ‹€
νΌλΈ”λ¦¬μ‹±μ˜ 경우 μŠ€ν¬λ¦°μƒ·/λ™μ˜μƒλ„ μΆ”κ°€ν•΄μ£Όλ©΄ μ’‹μ•„μš”!

Resolves: #312

πŸ“ƒ μž‘μ—…λ‚΄μš©

PRμ—μ„œ ν•œ μž‘μ—…μ„ μž‘μ„±ν•΄μ£Όμ„Έμš”!
corsμ—μ„œ 버셀 url을 μΆ”κ°€ν•˜μ˜€μŠ΅λ‹ˆλ‹€

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

κ΅¬ν˜„ μ‹œμ— κ³ λ―Όμ΄μ—ˆλ˜ 점듀 ν˜Ήμ€ νŠΉμ • 뢀뢄에 λŒ€ν•œ μ˜λ„κ°€ μžˆμ—ˆλ‹€λ©΄ PR 리뷰의 이해λ₯Ό 돕기 μœ„ν•΄ μ„œμˆ ν•΄μ£Όμ„Έμš”!

λ˜ν•œ λ¦¬λ·°μ–΄μ—κ²Œ νŠΉμ • 뢀뢄에 λŒ€ν•œ 집쀑 ν˜Ήμ€ μ½”λ©˜νŠΈ ν˜Ήμ€ μ§ˆλ¬Έμ„ μš”μ²­ν•˜λŠ” κ²½μš°μ— μž‘μ„±ν•˜λ©΄ μ’‹μ•„μš”!

e.g. μž‘μ—…μ„ 끝내야할 μ‹œκ°„μ΄ μ–Όλ§ˆ μ—†μ–΄ ν™•μž₯μ„±λ³΄λ‹€λŠ” λ™μž‘μ„ μœ„μ£Όλ‘œ λ§Œλ“€μ—ˆμ–΄μš”! κ°μ•ˆν•˜κ³  λ¦¬λ·°ν•΄μ£Όμ„Έμš”!

βœ… PR 체크리슀트

ν…œν”Œλ¦Ώ 체크리슀트 말고도 μΆ”κ°€μ μœΌλ‘œ ν•„μš”ν•œ μ²΄ν¬λ¦¬μŠ€νŠΈλŠ” μΆ”κ°€ν•΄μ£Όμ„Έμš”!

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. .env, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "ν™˜κ²½κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?
  • 이 μž‘μ—…μœΌλ‘œ 인해 λ°œμƒν•œ λ³€κ²½ 사항이 Resource μ„œλ²„μ—λ„ λ°˜μ˜λ˜μ—ˆλ‚˜μš”?

🎸 기타

@Umjiseung Umjiseung added the 0️⃣Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰ label Apr 12, 2024
@Umjiseung Umjiseung self-assigned this Apr 12, 2024
@Umjiseung Umjiseung linked an issue Apr 12, 2024 that may be closed by this pull request
cors μΆ”κ°€ #312
Closed
@Umjiseung Umjiseung merged commit f7d6092 into main Apr 12, 2024
1 check passed
@Umjiseung Umjiseung deleted the 312-cors-add branch April 12, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@googoo81 googoo81 googoo81 approved these changes

@dolong2 dolong2 Awaiting requested review from dolong2 dolong2 is a code owner

@KimTaeO KimTaeO Awaiting requested review from KimTaeO KimTaeO is a code owner

@baekteun baekteun Awaiting requested review from baekteun baekteun is a code owner

Assignees

@Umjiseung Umjiseung

Labels
0️⃣Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cors μΆ”κ°€
2 participants
@Umjiseung @googoo81