๐ :: ํ์๊ฐ์ ์๋ฝ์์ UserRole ์ถ๊ฐ #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Umjiseung
added
1๏ธโฃPriority: High
KimTaeO
reviewed
May 1, 2024
There was a problem hiding this comment.
ํ์ฌ SignUpํ๋ ๋ก์ง์์๋ userRole์ ์ ์ฅํ๋๋ฐ
์ด ๋ถ๋ถ์ ์ญ์ ํ๋ ๊ฒ์ด ์ด๋จ๊น์?
SignUpService
Comment on lines
31
to
47
| private fun acceptStudent(id: Long, acceptUserReqDto: AcceptUserReqDto) { | ||
| val user = acceptUserReqDto.toStudentEntity(getUser(id)) | ||
| saveUserRole(user, acceptUserReqDto.userRoleType) | ||
| userRepository.save(user) | ||
| } | ||
|
|
||
| private fun acceptTeacher(id: Long, acceptUserReqDto: AcceptUserReqDto) { | ||
| val user = acceptUserReqDto.toTeacherEntity(getUser(id)) | ||
| saveUserRole(user, acceptUserReqDto.userRoleType) | ||
| userRepository.save(user) | ||
| } | ||
|
|
||
| private fun acceptGraduate(id: Long, acceptUserReqDto: AcceptUserReqDto) { | ||
| val user = acceptUserReqDto.toGraduateEntity(getUser(id)) | ||
| saveUserRole(user, acceptUserReqDto.userRoleType) | ||
| userRepository.save(user) | ||
| } |
There was a problem hiding this comment.
์ค๋ณต๋๋ ๋ก์ง์ ๋ฐ์ผ๋ก ๋นผ์ ์ค๋ณต์ ์์จ ์ ์์ง ์์๊น์
There was a problem hiding this comment.
4418f09
saveUser ์ถ๊ฐํ์ฌ ์ค๋ณต์ ์ต์ํํ์ด์!
KimTaeO
reviewed
May 1, 2024
KimTaeO
reviewed
May 3, 2024
Comment on lines
31
to
44
| private fun acceptStudent(id: Long, acceptUserReqDto: AcceptUserReqDto) { | ||
| val user = acceptUserReqDto.toEntity(getUser(id)) | ||
| saveUser(user, acceptUserReqDto) | ||
| } | ||
|
|
||
| private fun acceptTeacher(id: Long, acceptUserReqDto: AcceptUserReqDto) { | ||
| val user = acceptUserReqDto.toEntity(getUser(id)) | ||
| saveUser(user, acceptUserReqDto) | ||
| } | ||
|
|
||
| private fun acceptGraduate(id: Long, acceptUserReqDto: AcceptUserReqDto) { | ||
| val user = acceptUserReqDto.toEntity(getUser(id)) | ||
| saveUser(user, acceptUserReqDto) | ||
| } |
There was a problem hiding this comment.
when ์กฐ๊ฑด๋ฌธ ์ฌ์ฉํ ํ์๋ ์์ด์ง๊ณ private ํจ์๋ฅผ ์ฌ์ฉํ ์ด์ ๋ ์์ด์ง๋ ๊ฒ ๊ฐ์์
There was a problem hiding this comment.
8cc83a7
๊ทธ๋ฌ๋ค์ ์์ ํ์ด์!
KimTaeO
approved these changes
May 3, 2024
Umjiseung
deleted the
318-membership-userroll-authorization-student-revision
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐ์
signUpํ ๋ UserRole์ ํ์์ผ๋ก ๊ณ ์ ํ์ฌ ํ์๊ฐ์ ์๋ฝ ํ์ UserRole์ด ๋ชจ๋ ํ์์ผ๋ก ๋ค์ด๊ฐ๋ ํ์์ด ์ผ์ด๋ ์์ ํ์์ต๋๋ค
Resolves: #318
๐ ์์ ๋ด์ฉ
ํ์๊ฐ์ ์๋ฝ์์ Body๋ก ๋ณด๋ธ UserRoleType์ ์ง์ด๋ฃ์ด ์ต์ข ์ ์ผ๋ก ์ฌ๋ฐ๋ฅธ ๊ถํ์ด ๋ค์ด๊ฐ๊ฒ๋ ํ์์ต๋๋ค
๐โโ๏ธ ๋ฆฌ๋ทฐ๋ ธํธ
โ PR ์ฒดํฌ๋ฆฌ์คํธ
.env,๋ ธ์ ,README)"API ๊ฐ๋ฐ ์๋ฃ๋์ด์","ํ๊ฒฝ๊ฐ ์ถ๊ฐ๋์์ด์")๐ธ ๊ธฐํ