Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: ํ”„๋กœ์ ํŠธ ๊ธฐ๋ณธ ์„ธํŒ… #2

Merged
merged 7 commits into from
Sep 26, 2024
Merged

๐Ÿ”€ :: ํ”„๋กœ์ ํŠธ ๊ธฐ๋ณธ ์„ธํŒ… #2

merged 7 commits into from
Sep 26, 2024

Conversation

Umjiseung
Copy link
Collaborator

ํ”„๋กœ์ ํŠธ ๊ธฐ๋ณธ ์„ธํŒ…์„ ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

  • ci ์Šคํฌ๋ฆฝํŠธ ์ถ”๊ฐ€
  • pr, issue ํ…œํ”Œ๋ฆฟ ์ถ”๊ฐ€
  • database, redis yml ์„ค์ • ์ถ”๊ฐ€
  • ์ฝ”๋“œ์˜ค๋„ˆ ์ถ”๊ฐ€

@Umjiseung Umjiseung added the โš™ Setting ํ™˜๊ฒฝ ์„ธํŒ… label Sep 26, 2024
@Umjiseung Umjiseung self-assigned this Sep 26, 2024
@Umjiseung Umjiseung linked an issue Sep 26, 2024 that may be closed by this pull request
ํ”„๋กœ์ ํŠธ ๊ธฐ๋ณธ ์„ธํŒ… ์ถ”๊ฐ€ #1
Closed
KimTaeO
KimTaeO reviewed Sep 26, 2024
View reviewed changes
.github/workflows/ci.yml
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
java-version: "17"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์—ฌ๊ธฐ์„œ ์ž๋ฐ” 17์„ ์‚ฌ์šฉํ•œ๋‹ค๋Š” ๊ฒƒ์€ ๊ฐœ๋ฐœ ์‹œ์—๋„ 17์„ ์‚ฌ์šฉํ•œ๋‹ค๋Š” ์ด์•ผ๊ธฐ๊ฐ€ ๋  ํ…๋ฐ.. ํŠน๋ณ„ํ•œ ์ด์œ ๊ฐ€ ์žˆ์œผ์‹ ๊ฐ€์š”?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํŠน๋ณ„ํ•œ ์ด์œ ๋Š” ์—†๋Š”๋ฐ ์ฒ˜์Œ์— ์ƒ์„ฑํ•  ๋•Œ 17๋กœ๋ฐ–์— ์ƒ์„ฑ์ด ์•ˆ๋˜์„œ ๊ทธ๋Ÿฐ ๊ฒƒ ๊ฐ™์•„์š” ์ œ ์ƒ๊ฐ์—๋Š” 11์„ ์“ฐ๋Š” ๊ฒƒ๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™๋‹ค๊ณ  ์ƒ๊ฐํ•ฉ๋‹ˆ๋‹ค ๋ณ„๋‹ค๋ฅธ ์ด์œ ๊ฐ€ ์—†๋‹ค๋ฉด์š”

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋‹จ์ˆœ ๊ถ๊ธˆ์ฆ์ด์—ˆ์Šต๋‹ˆ๋‹ค ํŽธํ•˜์‹ ๋Œ€๋กœ ์ง„ํ–‰ํ•ด์ฃผ์„ธ์š”~

KimTaeO
KimTaeO reviewed Sep 26, 2024
View reviewed changes
Copy link

@KimTaeO KimTaeO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

branch protection rule๋„ ์ ์šฉํ•ด์ฃผ์„ธ์š”~~

@Umjiseung Umjiseung changed the base branch from master to main September 26, 2024 06:58
@Umjiseung
Copy link
Collaborator Author

branch protection rule๋„ ์ ์šฉํ•ด์ฃผ์„ธ์š”~~

์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค

@Umjiseung Umjiseung merged commit 27d51b7 into main Sep 26, 2024
1 check passed
@Umjiseung Umjiseung deleted the setting/1-project-default-setting branch September 26, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KimTaeO KimTaeO KimTaeO approved these changes

@ta2ye0n ta2ye0n ta2ye0n approved these changes

Assignees

@Umjiseung Umjiseung

Labels
โš™ Setting ํ™˜๊ฒฝ ์„ธํŒ…
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ํ”„๋กœ์ ํŠธ ๊ธฐ๋ณธ ์„ธํŒ… ์ถ”๊ฐ€
3 participants
@Umjiseung @KimTaeO @ta2ye0n