인증제 폼 조회 기능 개발 + 엔티티 추가 #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ani2689
reviewed
Jun 5, 2024
| import team.msg.sms.domain.authentication.model.GroupAuthenticationArea | ||
|
|
||
| interface QueryGroupAuthenticationAreaPort { | ||
| fun queryGroupAuthenticationArea() : List<GroupAuthenticationArea> |
There was a problem hiding this comment.
Suggested change
| fun queryGroupAuthenticationArea() : List<GroupAuthenticationArea> | |
| fun queryGroupAuthenticationArea(): List<GroupAuthenticationArea> |
| @Service | ||
| class GetSelectorSectionValueServiceImpl ( | ||
| private val selectorSectionValuePort: SelectorSectionValuePort | ||
| ): GetSelectorSectionValueService{ |
There was a problem hiding this comment.
Suggested change
| ): GetSelectorSectionValueService{ | |
| ) : GetSelectorSectionValueService { |
louis7308
reviewed
Jun 6, 2024
|
|
||
| import team.msg.sms.domain.file.dto.res.FileResponseData | ||
|
|
||
| data class AuthenticationFormResponseData( |
There was a problem hiding this comment.
이거 한 Area 에 대한 AuthenticationForm 응답값인거 같아서
AuthenticationAreaFormResponseData 로 하는건 어떠신가요?
louis7308
reviewed
Jun 6, 2024
louis7308
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 배경 및 개요
선생님이 만드신 인증제 폼을 조회하는 기능을 개발하였습니다
Resolves: #{348}
📃 작업내용
총 5개의 테이블이 추가되었습니다 참고해주세요.
🙋♂️ 리뷰노트
작업을 하며 정신을 놓고 해서 불편한 점이 한두가지가 아닐꺼 같습니다 커멘트는 언제든지 환영입니다 !!
✅ PR 체크리스트
.env,노션,README)"API 개발 완료됐어요","환경값 추가되었어요")🎸 기타