-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
인증제 폼 조회 기능 개발 + 엔티티 추가 #349
Conversation
import team.msg.sms.domain.authentication.model.GroupAuthenticationArea | ||
|
||
interface QueryGroupAuthenticationAreaPort { | ||
fun queryGroupAuthenticationArea() : List<GroupAuthenticationArea> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fun queryGroupAuthenticationArea() : List<GroupAuthenticationArea> | |
fun queryGroupAuthenticationArea(): List<GroupAuthenticationArea> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정 했습니다 :) 커밋내용
@Service | ||
class GetSelectorSectionValueServiceImpl ( | ||
private val selectorSectionValuePort: SelectorSectionValuePort | ||
): GetSelectorSectionValueService{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
): GetSelectorSectionValueService{ | |
) : GetSelectorSectionValueService { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정 했습니다 :) 커밋내용
|
||
import team.msg.sms.domain.file.dto.res.FileResponseData | ||
|
||
data class AuthenticationFormResponseData( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 한 Area 에 대한 AuthenticationForm 응답값인거 같아서
AuthenticationAreaFormResponseData 로 하는건 어떠신가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혼동안오게 그런식으로 하겠습니다 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드 작업하시느라 수고하셨습니다!
전반적으로 코드를 잘 작성해주셔서 읽기 편했습니다. 감사합니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~
💡 배경 및 개요
선생님이 만드신 인증제 폼을 조회하는 기능을 개발하였습니다
Resolves: #{348}
📃 작업내용
총 5개의 테이블이 추가되었습니다 참고해주세요.
🙋♂️ 리뷰노트
작업을 하며 정신을 놓고 해서 불편한 점이 한두가지가 아닐꺼 같습니다 커멘트는 언제든지 환영입니다 !!
✅ PR 체크리스트
.env
,노션
,README
)"API 개발 완료됐어요"
,"환경값 추가되었어요"
)🎸 기타