학생 폼 제출 #355
Merged
학생 폼 제출 #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature/350-user-form-value
… feature/350-user-form-value
Closed
ani2689
approved these changes
Jun 7, 2024
...core/src/main/kotlin/team/msg/sms/domain/authentication/dto/req/SubmitUserFormRequestData.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 배경 및 개요
학생 폼 제출 기능을 개발하였습니다.
Resolves: #350
📃 작업내용
학생 폼 제출 기능 개발을 하던 중 빼먹은 컬럼이 있어 추가 하였고 인증제 GroupAuthenticationArea를 하나로 묶어줄 수 있는 AuthenticationForm 테이블을 추가하게 되었습니다.
🙋♂️ 리뷰노트
속도에 집중하다 보니 예외처리가 이루어지지 않았습니다. + 외래키가 맺어지지 않았기 때문에 나중에 유효성? 실제 있는 UUID인지를 검사하는 로직을 추가하는게 좋을거 같습니다 .
✅ PR 체크리스트
.env,노션,README)"API 개발 완료됐어요","환경값 추가되었어요")🎸 기타