선생님 학생 채점 기능 개발 #387
Merged
선생님 학생 채점 기능 개발 #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
enbraining
reviewed
Jul 5, 2024
| .fetch() | ||
|
|
||
| println(setIds) | ||
| println(setIds.all { it in userFormValueIds }) |
There was a problem hiding this comment.
println을 사용한 로그 출력은 지우는 것이 좋을 것 같아요!
… feature/386-teacher-grading-form
baekteun
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 배경 및 개요
학생이 제출한 폼을 채점하는 기능을 개발하였습니다.
Resolves: #386
📃 작업내용
markigValue 엔티티 수정 및 userFormValue의 setId로 검사하는 exists 함수 생성
채점 저장 기능 개발 및 채점 완료 시 UNDER_RIVIEW로 상태 변경 및 totalScore 갱신 로직 추가
🙋♂️ 리뷰노트
exist 함수를 queryDSL로 해서 더 개선 해볼수있을거 같으면 코드리뷰 부탁드립니다 ~
✅ PR 체크리스트
.env,노션,README)"API 개발 완료됐어요","환경값 추가되었어요")🎸 기타