-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial IDExtender API #17
base: master
Are you sure you want to change the base?
Conversation
The readme should also note the fact that just because the API is present, the returned values may or may not actually be higher than vanilla, and mods should always inspect the returned values to ensure that they fit their needed range. |
Any news on this, or can I move forward with this proposal on my side? |
Honestly kind of forgot about this. If you want to move forward with something, I can match whatever API you've got. |
The only extra addition is the following notice paragraph in the readme for API users, due to how endlessids can have its features toggled on/off, and i feel like that should also be mentioned here so that people validate the returned values before using them, instead of assuming that it's always larger than vanilla.
|
Ah, I almost forgot, DataWatcher should also be added, I saw someone on the legacy modding discord complaining about the vanilla datawatcher count, so exposing that in the API could be useful. https://github.com/GTMEGA/EndlessIDs/blob/interop/src/main/java/idextender/DataWatcher.java |
This adds a new "dummy" mod, with the ID
idextender
.It then provides a new API under the
idextender
package, which can be used by other mods to create hard dependencies on extended metadata. This API does seem a little bit obtuse, but the intention of the API is so that mods can create this hard dependency on extended metadata, rather than any specific ID extension mod.The goal is that other ID extension mods can include this same API, and provide the
idextender
dummy mod. So instead of hard dependency on NEID, a mod can hard dependency onidextender
, and just check that it's getting the metadata increase it wants.Usage of the new API is covered in the README, and once this is merged I will be updating GT5U to use it as an example.