Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tx pagination #3530

Merged
merged 8 commits into from
Nov 30, 2023
Merged

fix: tx pagination #3530

merged 8 commits into from
Nov 30, 2023

Conversation

UncleSamtoshi
Copy link
Contributor

@UncleSamtoshi UncleSamtoshi commented Nov 10, 2023 •
edited
Loading

  • removes pending incoming onchain transactions from transactions query

@github-actions github-actions bot added the core label Nov 10, 2023
@UncleSamtoshi UncleSamtoshi force-pushed the fix-tx-pagination branch 2 times, most recently from 8a5d8e5 to 570c502 Compare November 13, 2023 17:56
@UncleSamtoshi UncleSamtoshi force-pushed the fix-tx-pagination branch 7 times, most recently from 4334b7f to 1e63441 Compare November 15, 2023 15:55
@UncleSamtoshi UncleSamtoshi marked this pull request as ready for review November 27, 2023 19:25
dolcalmi
dolcalmi requested changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@dolcalmi dolcalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just minor changes/questions

core/api/src/app/accounts/get-account-transactions-for-contact.ts Outdated Show resolved Hide resolved
core/api/src/app/wallets/get-transactions-by-addresses.ts Outdated Show resolved Hide resolved
core/api/src/app/wallets/get-transactions-by-addresses.ts Outdated Show resolved Hide resolved
core/api/src/app/wallets/get-transactions-for-wallet.ts Outdated Show resolved Hide resolved
core/api/src/graphql/public/types/object/consumer-account.ts Outdated Show resolved Hide resolved
core/api/src/services/ledger/paginated-ledger.ts Show resolved Hide resolved
core/api/src/services/ledger/paginated-ledger.ts Show resolved Hide resolved
core/api/src/services/ledger/paginated-ledger.ts Show resolved Hide resolved
vindard
vindard approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@vindard vindard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now

@UncleSamtoshi UncleSamtoshi enabled auto-merge (squash) November 30, 2023 19:25
@UncleSamtoshi UncleSamtoshi merged commit eecbbd3 into main Nov 30, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasburtey nicolasburtey nicolasburtey left review comments

@dolcalmi dolcalmi dolcalmi approved these changes

@vindard vindard vindard approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@UncleSamtoshi @dolcalmi @nicolasburtey @vindard