chore: prevent WalletInvoice deletion #3557
Conversation
UncleSamtoshi
force-pushed
the
prevent-invoice-deletion
branch
2 times, most recently
from
4c1e047
to
455dec5
Compare
UncleSamtoshi
force-pushed
the
prevent-invoice-deletion
branch
from
f21ea22
to
416b895
Compare
| @@ -302,6 +316,7 @@ const updatePendingInvoiceBeforeFinally = async ({ | |||
| "invoices.finalRecipient": JSON.stringify(recipientWalletDescriptor), | |||
| }) | |||
|
|
|||
| // Is this crossing the lock boundary? | |||
There was a problem hiding this comment.
please remove, also not sure... what you mean? this can be done outside the lock but need to be done previous to ledger record (that must be inside lock)
There was a problem hiding this comment.
I will remove it, but lnInvoiceLookup is populated before the lock, so its state could change by the time the lock is acquired.
There was a problem hiding this comment.
ahh I thought you referred to settle... you are right, feel free to move it
| @@ -69,6 +69,7 @@ interface WalletInvoiceRecord { | |||
| currency: string | |||
| timestamp: Date | |||
| selfGenerated: boolean | |||
| processingCompleted?: boolean | |||
There was a problem hiding this comment.
why do we need to add it as optional? isnt default value working?
There was a problem hiding this comment.
Isn't default value only used on write? I have a database migration that will go back and populate this field and then i will make it non optional.
UncleSamtoshi
force-pushed
the
prevent-invoice-deletion
branch
from
416b895
to
6a13d19
Compare
processingCompletedfield to replace deleting canceled invoicesTo Do:
processingCompletedfields totrueprocessingCompletedfield to be non-optional