Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): unify separated no-implicit-any checks #3559

Merged
merged 1 commit into from
Nov 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions core/api/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,8 @@ integration-in-ci:
unit-in-ci:
. ./.env && \
LOGLEVEL=warn $(BIN_DIR)/jest --config ./test/unit/jest.config.js --ci --bail --maxWorkers=50%
check-implicit:
pnpm run tsc-check-noimplicitany

check-code: check-implicit
check-code:
pnpm run tsc-check
pnpm run eslint-check
pnpm run build
Expand Down
1 change: 0 additions & 1 deletion core/api/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"name": "api",
"scripts": {
"tsc-check-noimplicitany": "tsc --noEmit -p tsconfig.no-implicit-any.json",
"tsc-check": "tsc --noEmit",
"madge-check": "madge --circular --extensions ts ./src",
"madge-check-tests": "madge --circular --extensions ts ./test",
Expand Down
1 change: 0 additions & 1 deletion core/api/src/debug/websocket/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"name": "galoy",
"type": "module",
"scripts": {
"tsc-check-noimplicitany": "tsc --noEmit -p tsconfig.no-implicit-any.json",
"tsc-check": "tsc --noEmit",
"eslint-check": "eslint \"{src,test}/**/*.ts\"",
"eslint-fix": "eslint \"{src,test}/**/*.ts\" --fix",
Expand Down
2 changes: 1 addition & 1 deletion core/api/src/debug/websocket/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"sourceMap": true,
"strict": true,
"target": "es2020",
"noImplicitAny": false,
"noImplicitAny": true,
"useUnknownInCatchVariables": false,
"esModuleInterop": true,
"baseUrl": "./",
Expand Down
5 changes: 1 addition & 4 deletions core/api/tsconfig-build.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
{
"extends": "./tsconfig.json",
"include": ["src/servers/**/*.ts", "src/**/*.d.ts"],
"compilerOptions": {
"noImplicitAny": true
}
"include": ["src/servers/**/*.ts", "src/**/*.d.ts"]
}
4 changes: 0 additions & 4 deletions core/api/tsconfig.d.json

This file was deleted.

1 change: 1 addition & 0 deletions core/api/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"esModuleInterop": true,
"baseUrl": "./",
"moduleResolution": "node",
"noImplicitAny": true,
"resolveJsonModule": true,
"paths": {
"@/*": [
Expand Down
12 changes: 0 additions & 12 deletions core/api/tsconfig.no-implicit-any.json

This file was deleted.

Loading